Skip to content

Conversation

@ferranAX
Copy link
Contributor

@ferranAX ferranAX commented Mar 6, 2025

No description provided.

Copy link
Contributor

@donato-ax donato-ax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to hard-code inside the function that the keys have to be port pairs? This is unnecessarily constraining the use of this function, no?

@ferranAX
Copy link
Contributor Author

ferranAX commented Mar 6, 2025

Why do we have to hard-code inside the function that the keys have to be port pairs? This is unnecessarily constraining the use of this function, no?

Yes. In theory we should only admit dictionaries with tuples of strings as input, as it is the output of our sax spectrum endpoint as well as the standard output of sax models. However, in serialization, the SDK converted the tuple[str, str] to a comma separated string. For this reason we implement this feature and to standardize the labels.

@donato-ax
Copy link
Contributor

Why do we have to hard-code inside the function that the keys have to be port pairs? This is unnecessarily constraining the use of this function, no?

Yes. In theory we should only admit dictionaries with tuples of strings as input, as it is the output of our sax spectrum endpoint as well as the standard output of sax models. However, in serialization, the SDK converted the tuple[str, str] to a comma separated string. For this reason we implement this feature and to standardize the labels.

@ferranAX why did the sdk do that? then there is something wrong with the sdk

@ferranAX
Copy link
Contributor Author

ferranAX commented Mar 6, 2025

Why do we have to hard-code inside the function that the keys have to be port pairs? This is unnecessarily constraining the use of this function, no?

Yes. In theory we should only admit dictionaries with tuples of strings as input, as it is the output of our sax spectrum endpoint as well as the standard output of sax models. However, in serialization, the SDK converted the tuple[str, str] to a comma separated string. For this reason we implement this feature and to standardize the labels.

@ferranAX why did the sdk do that? then there is something wrong with the sdk

Indeed, but there is a presentation today. I believe it's best to get this, even if it's just a temporary fix.

@ferranAX ferranAX merged commit 6740dac into main Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants