Implement postmark#28
Open
Azfletch wants to merge 15 commits into
Open
Conversation
krisquigley
reviewed
Nov 30, 2018
…to development & prod. Added unit test
added to .gitignore for future
… into feature/implement_postmark
krisquigley
reviewed
Jan 14, 2019
| mail( | ||
| to: notification.email, | ||
| subject: "Arrons blog has been updated!", | ||
| from: "arron.fletcher@shiftcommerce.com", |
There was a problem hiding this comment.
I would change this to a personal email address
| config.action_mailer.default_url_options = { host: "localhost:4000" } | ||
| config.action_mailer.asset_host = "http://localhost:4000" | ||
| config.action_mailer.default_url_options = { host: ENV.fetch("MAILER_HOST") } | ||
| config.action_mailer.asset_host = ENV.fetch("MAILER_HOST") |
There was a problem hiding this comment.
I would remove all this stuff from application.rb as you are defining them in development.rb and production.rb already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope of this PR is to:
Implement Postmark for delivering SMTP emails and use environment variables for sensitive credentials.
Add Tests
Related Issue: #15