Skip to content

chore: drop dead legacy oracle mappings#22034

Merged
benesjan merged 1 commit intonextfrom
jan/drop-dead-legacy-oracle-mappings
Mar 30, 2026
Merged

chore: drop dead legacy oracle mappings#22034
benesjan merged 1 commit intonextfrom
jan/drop-dead-legacy-oracle-mappings

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented Mar 26, 2026

Dropping unused legacy oracle mappings.

I think the first 2 below got in because SponsoredFPC used to be pinned and then it was unpinned. Not sure about utilityEmitOffchainEffect but it's not in any pinned contract bytecode (the bytecode contains full source code).

The backport PR is here - created the backport manually as I wanted to see if tests actually pass on v4-next. So if you approve this one please approve the backport as well.

Summary

  • Remove 3 legacy oracle mappings that are not called by any pinned v4 protocol contract:
    • privateIsSideEffectCounterRevertible
    • privateNotifySetPublicTeardownFunctionCall
    • utilityEmitOffchainEffect
  • Verified by decoding the Brillig bytecode from the pinned protocol contract artifacts on v4-next — none of these oracle names appear in any of the 6 pinned contracts.

Test plan

  • CI passes (no functional change — these mappings were dead code)

🤖 Generated with Claude Code

Remove 3 legacy oracle mappings that are not called by any pinned v4
protocol contract: privateIsSideEffectCounterRevertible,
privateNotifySetPublicTeardownFunctionCall, and utilityEmitOffchainEffect.

Verified by decoding the Brillig bytecode from the pinned protocol
contract artifacts on v4-next.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Base automatically changed from merge-train/fairies to next March 26, 2026 04:08
@benesjan benesjan requested a review from mverzilli March 26, 2026 11:14
@benesjan benesjan added this pull request to the merge queue Mar 30, 2026
@AztecBot
Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/108bb31b07816c65�108bb31b07816c658;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_offchain_payment.test.ts (57s) (code: 0)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/1913ae1c5bfc2af5�1913ae1c5bfc2af58;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "proposer invalidates multiple checkpoints" (348s) (code: 0) group:e2e-p2p-epoch-flakes

Merged via the queue into next with commit ca3a9c2 Mar 30, 2026
19 checks passed
@benesjan benesjan deleted the jan/drop-dead-legacy-oracle-mappings branch March 30, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants