chore: drop dead legacy oracle mappings#22034
Merged
Conversation
Remove 3 legacy oracle mappings that are not called by any pinned v4 protocol contract: privateIsSideEffectCounterRevertible, privateNotifySetPublicTeardownFunctionCall, and utilityEmitOffchainEffect. Verified by decoding the Brillig bytecode from the pinned protocol contract artifacts on v4-next. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mverzilli
approved these changes
Mar 30, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping unused legacy oracle mappings.
I think the first 2 below got in because
SponsoredFPCused to be pinned and then it was unpinned. Not sure aboututilityEmitOffchainEffectbut it's not in any pinned contract bytecode (the bytecode contains full source code).The backport PR is here - created the backport manually as I wanted to see if tests actually pass on
v4-next. So if you approve this one please approve the backport as well.Summary
privateIsSideEffectCounterRevertibleprivateNotifySetPublicTeardownFunctionCallutilityEmitOffchainEffectTest plan
🤖 Generated with Claude Code