Skip to content

chore: backport - drop dead legacy oracle mappings#22035

Merged
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
jan/backport-drop-dead-legacy-oracle-mappings
Mar 30, 2026
Merged

chore: backport - drop dead legacy oracle mappings#22035
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
jan/backport-drop-dead-legacy-oracle-mappings

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented Mar 26, 2026

Backport of #22034.

Remove 3 legacy oracle mappings that are not called by any pinned v4
protocol contract: privateIsSideEffectCounterRevertible,
privateNotifySetPublicTeardownFunctionCall, and utilityEmitOffchainEffect.

Verified by decoding the Brillig bytecode from the pinned protocol
contract artifacts on v4-next.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@AztecBot
Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/b55ef9f3da3a60b1�b55ef9f3da3a60b18;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_proof_fails.parallel.test.ts "does not allow submitting proof after epoch end" (210s) (code: 0) group:e2e-p2p-epoch-flakes

@benesjan benesjan requested a review from mverzilli March 26, 2026 11:14
@benesjan benesjan changed the title chore: drop dead legacy oracle mappings chore: backport - drop dead legacy oracle mappings Mar 26, 2026
@benesjan benesjan merged commit 4d8a102 into backport-to-v4-next-staging Mar 30, 2026
15 of 16 checks passed
@benesjan benesjan deleted the jan/backport-drop-dead-legacy-oracle-mappings branch March 30, 2026 09:49
github-merge-queue bot pushed a commit that referenced this pull request Mar 30, 2026
Dropping unused legacy oracle mappings.

I think the first 2 below got in because `SponsoredFPC` used to be
pinned and then it was unpinned. Not sure about
`utilityEmitOffchainEffect` but it's not in any pinned contract bytecode
(the bytecode contains full source code).

The backport PR is
[here](#22035) -
created the backport manually as I wanted to see if tests actually pass
on `v4-next`. So if you approve this one please approve the backport as
well.

## Summary
- Remove 3 legacy oracle mappings that are not called by any pinned v4
protocol contract:
  - `privateIsSideEffectCounterRevertible`
  - `privateNotifySetPublicTeardownFunctionCall`
  - `utilityEmitOffchainEffect`
- Verified by decoding the Brillig bytecode from the pinned protocol
contract artifacts on v4-next — none of these oracle names appear in any
of the 6 pinned contracts.

## Test plan
- CI passes (no functional change — these mappings were dead code)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
AztecBot added a commit that referenced this pull request Mar 31, 2026
BEGIN_COMMIT_OVERRIDE
chore: backport - drop dead legacy oracle mappings (#22035)
fix: backport timestamp and anvil fixes (#22110)
fix(archiver): swallow error when rollup contract not yet finalized on
L1 (#22156)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants