Skip to content

fix(ci): correct authorization_selector_collision error snapshot#22771

Merged
vezenovm merged 1 commit intomerge-train/fairiesfrom
claudebox/fix-noir-snapshot-ci
Apr 24, 2026
Merged

fix(ci): correct authorization_selector_collision error snapshot#22771
vezenovm merged 1 commit intomerge-train/fairiesfrom
claudebox/fix-noir-snapshot-ci

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

The expected_error snapshot for authorization_selector_collision contains a phantom line check_parent_traits_are_implemented: missing trait ID that nargo does not emit (the string does not exist anywhere in noir/noir-repo). CI on merge-train/fairies runs this test on every PR with caching disabled, so the mismatch was blocking the branch.

Actual nargo output is a stable 5 errors; expected was 6. Remove the phantom line so the snapshot matches.

Failing run: http://ci.aztec-labs.com/1777040996623663 (sub-step log b6fb83475dc5b0b0). Full analysis: https://gist.github.com/AztecBot/e4536bdfe3f12f3cde1f5c3d9a23fe55

Verified locally — all 51 contracts in noir-contracts-comp-failures pass after the edit.

ClaudeBox log: https://claudebox.work/s/56b0f2729e6fb5d3?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Apr 24, 2026
@vezenovm vezenovm marked this pull request as ready for review April 24, 2026 15:38
@vezenovm vezenovm merged commit 473e136 into merge-train/fairies Apr 24, 2026
52 of 60 checks passed
@vezenovm vezenovm deleted the claudebox/fix-noir-snapshot-ci branch April 24, 2026 15:39
@AztecBot
Copy link
Copy Markdown
Collaborator Author

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants