fix(ci): regenerate authorization_selector_collision snapshot after noir bump#22773
Closed
AztecBot wants to merge 2 commits intomerge-train/fairiesfrom
Closed
fix(ci): regenerate authorization_selector_collision snapshot after noir bump#22773AztecBot wants to merge 2 commits intomerge-train/fairiesfrom
AztecBot wants to merge 2 commits intomerge-train/fairiesfrom
Conversation
AztecBot
added
ci-draft
Contributor
|
Succeeded by #22771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
contracts/authorization_selector_collision/snapshot innoir-projects/noir-contracts-comp-failures/was authored againstthe noir at commit
ad02a20cd8(pre-bump). Nightly-2026-04-23(#22653,
f39ac4f574) removed thecheck_parent_traits_are_implementedfunction and folded its super-trait bound check into
check_trait_impl_where_clause_matches_trait_where_clause.Both functions shared an early-return guard when
trait_impl.trait_idis
None(the case this test hits, because the cascading resolutionfailures above it never bind a trait ID). In the old compiler the
guard fired twice — once per function — emitting two
missing trait IDerrors. In the new compiler it fires once.
Regenerated the snapshot to drop the now-absent
check_parent_traits_are_implemented: missing trait IDline.Verified locally:
./bootstrap.sh test authorization_selector_collisionreports
✓ Compilation failed as expected with correct error(s).See http://ci.aztec-labs.com/b6fb83475dc5b0b0 for the failing run on
PR #22765.
ClaudeBox log: https://claudebox.work/s/d72e1449fb744a16?run=79