fix(ipc): auto-claim shm client slots#24236
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Multiple SHM clients were defaulting to producer slot 0. In the wsdb/AVM topology that means separate clients can share one request/response ring pair and steal or mis-correlate responses. The fix adds a small owner table to the existing MPSC doorbell mapping so clients can atomically claim distinct slots.
This intentionally does not try to recover stale in-flight requests left by a crashed client. Clean disconnect releases the claimed slot for reuse.
Validation
Note: the fresh next-based worktree had no yarn install state, so the TS world-state test is left for CI here. It passed earlier in the existing built ipc-5 worktree before this was split into a standalone PR.