chore: add writing-e2e-tests skill#24597
Merged
Merged
Conversation
6057fdb to
1dcf5bc
Compare
1dcf5bc to
d530a48
Compare
spalladino
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
yarn-project/.claude/skills/writing-e2e-tests/SKILL.md: a skill that gives an agent everything it needs to place, structure, and write a robust e2e test with little guidance. Written against the v5-next e2e layout (category directories with per-category READMEs and context classes).What it covers
itin an existing suite → new file on an existing context/harness → new standalone test.automine/viaAutomineTestContext,single-node/viasetupWithProver/setupBlockProducer,multi-node/viaMultiNodeTestContexton the mock-gossip bus,p2p/viaP2PNetworkTeston real libp2p, pluscomposed/,infra/,spartan/,bench/), the multi-node-vs-p2p decision rule, pointers to the per-category READMEs as the authoritative reference, file naming (describematches path, header comment), automatic CI registration throughbootstrap.shglobs,.parallel.test.tssemantics, and jest/bash timeout sync.SetupOptions), the standard suite file shape, one-environment-per-file, preset spread order, guarded teardown.fixtures/wait_helpers.ts, context waiters,ChainMonitor), shared helpers and co-located*_test_helpers.ts, simulators withafterEachchecks, shared error constants.test(e2e)/perf(e2e)/chore(e2e)speedup PRs and their tracking issues — avoid unneeded setup, genesis seeding over setup txs,BatchCallbatching overPromise.alloverlap (with the PXE-serialization caveat), warping dead waits withmarkProvenAndWarp/warpWithSequencersPaused("an honest wait beats a flaky warp"), named timing profiles over ad-hoc cadences, and measuring with thetestSpaninstrumentation +track-e2e-timesskill before optimizing.syncChainTiptag awareness, pipelining timing margins +findSlotsWithProposers, invariant-not-exact-value assertions, L1 account/nonce and port hygiene, freeze-L1-across-restarts, gossip-mesh readiness viarunGossipScenario, fee padding, determinism, honest timeouts), plusdeflaker.shvalidation and.test_patterns.ymlas a last resort.All helper/API names cited were verified to exist on
merge-train/spartan-v5(AutomineTestContext.setup,setupWithProver/setupBlockProducer,MOCK_GOSSIP_MULTI_VALIDATOR_OPTS,wait_helpers.tswaiters,warpWithSequencersPaused,markProvenAndWarp,testSpan/TEST_TIMING_FILE,runGossipScenario,waitForP2PMeshConnectivity,findSlotsWithProposers,getPaddedMaxFeesPerGas, etc.). Genesis-prefill techniques that only exist in still-open speedup PRs are described as themes to look for rather than as concrete APIs.