chore: update Noir to v1.0.0-beta.25#24907
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
AztecBot
force-pushed
the
cb/c0d43cb515b0
branch
from
July 22, 2026 14:34
da33d29 to
2f3c924
Compare
| | StructValue; | ||
|
|
||
| /** An exported value together with the name of the global that produced it. */ | ||
| export interface AbiNamedValue { |
| outputs: { | ||
| structs: Record<string, AbiType[]>; | ||
| globals: Record<string, AbiValue[]>; | ||
| globals: Record<string, (AbiNamedValue | AbiValue)[]>; |
Contributor
There was a problem hiding this comment.
Keep AbiValue for backward compatibility to already built artifacts. Could look to remove in next major release
IlyasRidhuan
approved these changes
Jul 23, 2026
IlyasRidhuan
marked this pull request as ready for review
July 23, 2026 13:22
IlyasRidhuan
requested review from
MirandaWood,
nventuro and
sirasistant
as code owners
July 23, 2026 13:22
## Summary Bumps `noir/noir-repo` from `v1.0.0-beta.22` to `v1.0.0-beta.25` (`c57152f9` → `75061fab15986eedee4e7d9104ff87dd9fa4ca10`) and applies the required follow-on compatibility updates. ## Changes - Updates the Noir submodule to `v1.0.0-beta.25`. - Refreshes `avm-transpiler/Cargo.lock` with targeted Noir-package updates and adapts the transpiler to the public `BrilligOpcodeLocation` / `BrilligFunctionId` APIs. - Refreshes `yarn-project/yarn.lock` for the beta.25 Noir packages. - Adapts aztec-nr macros and helpers to beta.25: - accounts for kernel-validated oracle outputs; - removes obsolete storage-proof and state-variable imports; - applies the beta.25 formatter output. - Normalizes beta.25's named contract globals before artifact-schema parsing, including storage-layout extraction, with regression coverage. - Refreshes the contract expansion and compile-failure snapshots produced by beta.25. - Excludes two new upstream compiler-only fixtures from Barretenberg's UltraHonk ACIR integration suite: one uses unsupported CallData blocks, and one intentionally optimizes to an empty circuit while retaining unused inputs. ## Verification - `cargo check --all-targets` in `avm-transpiler` - `yarn workspace @aztec/stdlib build` - `yarn format stdlib` - `yarn lint stdlib` - `yarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts` - `./noir-projects/contract-snapshots/bootstrap.sh test` (60 passed) - `./barretenberg/acir_tests/bootstrap.sh` - CI3 passed on the complete pre-squash tree; the final head contains the same change set as one commit on current `next`. --- *Created by [claudebox](https://claudebox.work/v2/sessions/c0d43cb515b09702/jobs/1) · group: `slackbot` · [Slack thread](https://aztecfoundation.slack.com/archives/C0B278STDMZ/p1784718350039199?thread_ts=1784718350.039199&cid=C0B278STDMZ)*
AztecBot
force-pushed
the
cb/c0d43cb515b0
branch
from
July 23, 2026 13:33
090e0d2 to
c3221fb
Compare
AztecBot
enabled auto-merge
July 23, 2026 13:33
Collaborator
Author
|
❌ Failed to cherry-pick to |
IlyasRidhuan
added a commit
that referenced
this pull request
Jul 24, 2026
## Summary Backport of #24907 to `v5-next` via `backport-to-v5-next-staging`. This replays the Noir `v1.0.0-beta.25` bump onto the v5 staging branch, including the Noir submodule update, avm-transpiler compatibility updates, yarn lockfile refresh, aztec-nr formatter/macros updates, contract snapshot refreshes, and stdlib artifact-loader changes. ## Conflict Resolution The cherry-pick conflicted in `yarn-project/stdlib/src/abi/contract_artifact.test.ts`. The resolution keeps the existing v5 `loadContractArtifactWithValidation` coverage and adds the beta.25 storage-global normalization tests from the original PR. ## Commit Structure 1. Cherry-pick of `b0ed85797a7bf8668950ab4078fc42eb42d69689` with the test conflict resolved in place. ## Verification - `git diff --check origin/backport-to-v5-next-staging..HEAD` - Strict conflict-marker scan: `rg -n '^(<<<<<<< |=======$|>>>>>>> )'` Could not run the focused stdlib test locally: `yarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts` first failed because the checkout had no Yarn install state. Preparing that state required the Noir bootstrap, but `DENOISE=0 ./bootstrap.sh` in `noir/` failed while trying to install `just@1.42.4` from crates.io due a tunnel/DNS error. The container also has Rust 1.85.0 while this branch expects Rust 1.89.0. --- *Created by [claudebox](https://claudebox.work/v2/sessions/edfda45656ef1ad6/jobs/1) · group: `slackbot` · [Slack thread](https://aztecprotocol.slack.com/archives/C0AGN2WT3CP/p1784820075707329?thread_ts=1784820075.707329&cid=C0AGN2WT3CP)*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
noir/noir-repofromv1.0.0-beta.22tov1.0.0-beta.25(
c57152f9→75061fab15986eedee4e7d9104ff87dd9fa4ca10) and applies therequired follow-on compatibility updates.
Changes
v1.0.0-beta.25.avm-transpiler/Cargo.lockwith targeted Noir-package updates andadapts the transpiler to the public
BrilligOpcodeLocation/BrilligFunctionIdAPIs.yarn-project/yarn.lockfor the beta.25 Noir packages.including storage-layout extraction, with regression coverage.
beta.25.
ACIR integration suite: one uses unsupported CallData blocks, and one
intentionally optimizes to an empty circuit while retaining unused inputs.
Verification
cargo check --all-targetsinavm-transpileryarn workspace @aztec/stdlib buildyarn format stdlibyarn lint stdlibyarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts./noir-projects/contract-snapshots/bootstrap.sh test(60 passed)./barretenberg/acir_tests/bootstrap.shchange set as one commit on current
next.Created by claudebox · group:
slackbot· Slack thread