Skip to content

chore: update Noir to v1.0.0-beta.25#24907

Merged
IlyasRidhuan merged 1 commit into
nextfrom
cb/c0d43cb515b0
Jul 23, 2026
Merged

chore: update Noir to v1.0.0-beta.25#24907
IlyasRidhuan merged 1 commit into
nextfrom
cb/c0d43cb515b0

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps noir/noir-repo from v1.0.0-beta.22 to v1.0.0-beta.25
(c57152f975061fab15986eedee4e7d9104ff87dd9fa4ca10) and applies the
required follow-on compatibility updates.

Changes

  • Updates the Noir submodule to v1.0.0-beta.25.
  • Refreshes avm-transpiler/Cargo.lock with targeted Noir-package updates and
    adapts the transpiler to the public BrilligOpcodeLocation /
    BrilligFunctionId APIs.
  • Refreshes yarn-project/yarn.lock for the beta.25 Noir packages.
  • Adapts aztec-nr macros and helpers to beta.25:
    • accounts for kernel-validated oracle outputs;
    • removes obsolete storage-proof and state-variable imports;
    • applies the beta.25 formatter output.
  • Normalizes beta.25's named contract globals before artifact-schema parsing,
    including storage-layout extraction, with regression coverage.
  • Refreshes the contract expansion and compile-failure snapshots produced by
    beta.25.
  • Excludes two new upstream compiler-only fixtures from Barretenberg's UltraHonk
    ACIR integration suite: one uses unsupported CallData blocks, and one
    intentionally optimizes to an empty circuit while retaining unused inputs.

Verification

  • cargo check --all-targets in avm-transpiler
  • yarn workspace @aztec/stdlib build
  • yarn format stdlib
  • yarn lint stdlib
  • yarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts
  • ./noir-projects/contract-snapshots/bootstrap.sh test (60 passed)
  • ./barretenberg/acir_tests/bootstrap.sh
  • CI3 passed on the complete pre-squash tree; the final head contains the same
    change set as one commit on current next.

Created by claudebox · group: slackbot · Slack thread

@AztecBot AztecBot added C-noir Component: Noir/Nargo ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 22, 2026
@IlyasRidhuan
IlyasRidhuan requested a review from TomAFrench July 22, 2026 11:54
@socket-security

socket-security Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​aztec/​noir-noir_js@​1.0.0-beta.22 ⏵ 1.0.0-beta.25N/AN/AN/AN/AN/A

View full report

| StructValue;

/** An exported value together with the name of the global that produced it. */
export interface AbiNamedValue {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noir preserves the name of the exported #[abi]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this was requested by @vezenovm so fyi on any followups that fairies want to make.

outputs: {
structs: Record<string, AbiType[]>;
globals: Record<string, AbiValue[]>;
globals: Record<string, (AbiNamedValue | AbiValue)[]>;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep AbiValue for backward compatibility to already built artifacts. Could look to remove in next major release

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto @vezenovm

Comment thread noir-projects/noir-contracts/bootstrap.sh

@TomAFrench TomAFrench left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyasRidhuan
IlyasRidhuan marked this pull request as ready for review July 23, 2026 13:22
@IlyasRidhuan
IlyasRidhuan removed the request for review from MirandaWood July 23, 2026 13:22
## Summary

Bumps `noir/noir-repo` from `v1.0.0-beta.22` to `v1.0.0-beta.25`
(`c57152f9` → `75061fab15986eedee4e7d9104ff87dd9fa4ca10`) and applies the
required follow-on compatibility updates.

## Changes

- Updates the Noir submodule to `v1.0.0-beta.25`.
- Refreshes `avm-transpiler/Cargo.lock` with targeted Noir-package updates and
  adapts the transpiler to the public `BrilligOpcodeLocation` /
  `BrilligFunctionId` APIs.
- Refreshes `yarn-project/yarn.lock` for the beta.25 Noir packages.
- Adapts aztec-nr macros and helpers to beta.25:
  - accounts for kernel-validated oracle outputs;
  - removes obsolete storage-proof and state-variable imports;
  - applies the beta.25 formatter output.
- Normalizes beta.25's named contract globals before artifact-schema parsing,
  including storage-layout extraction, with regression coverage.
- Refreshes the contract expansion and compile-failure snapshots produced by
  beta.25.
- Excludes two new upstream compiler-only fixtures from Barretenberg's UltraHonk
  ACIR integration suite: one uses unsupported CallData blocks, and one
  intentionally optimizes to an empty circuit while retaining unused inputs.

## Verification

- `cargo check --all-targets` in `avm-transpiler`
- `yarn workspace @aztec/stdlib build`
- `yarn format stdlib`
- `yarn lint stdlib`
- `yarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts`
- `./noir-projects/contract-snapshots/bootstrap.sh test` (60 passed)
- `./barretenberg/acir_tests/bootstrap.sh`
- CI3 passed on the complete pre-squash tree; the final head contains the same
  change set as one commit on current `next`.

---
*Created by [claudebox](https://claudebox.work/v2/sessions/c0d43cb515b09702/jobs/1) · group: `slackbot` · [Slack thread](https://aztecfoundation.slack.com/archives/C0B278STDMZ/p1784718350039199?thread_ts=1784718350.039199&cid=C0B278STDMZ)*
@AztecBot
AztecBot enabled auto-merge July 23, 2026 13:33
@AztecBot
AztecBot added this pull request to the merge queue Jul 23, 2026
@IlyasRidhuan
IlyasRidhuan removed this pull request from the merge queue due to a manual request Jul 23, 2026
@IlyasRidhuan
IlyasRidhuan added this pull request to the merge queue Jul 23, 2026
Merged via the queue into next with commit b0ed857 Jul 23, 2026
34 checks passed
@IlyasRidhuan
IlyasRidhuan deleted the cb/c0d43cb515b0 branch July 23, 2026 15:02
@AztecBot

Copy link
Copy Markdown
Collaborator Author

❌ Failed to cherry-pick to v5-next due to conflicts. (🤖) View backport run.

IlyasRidhuan added a commit that referenced this pull request Jul 24, 2026
## Summary
Backport of #24907
to `v5-next` via `backport-to-v5-next-staging`.

This replays the Noir `v1.0.0-beta.25` bump onto the v5 staging branch,
including the Noir submodule update, avm-transpiler compatibility
updates, yarn lockfile refresh, aztec-nr formatter/macros updates,
contract snapshot refreshes, and stdlib artifact-loader changes.

## Conflict Resolution
The cherry-pick conflicted in
`yarn-project/stdlib/src/abi/contract_artifact.test.ts`. The resolution
keeps the existing v5 `loadContractArtifactWithValidation` coverage and
adds the beta.25 storage-global normalization tests from the original
PR.

## Commit Structure
1. Cherry-pick of `b0ed85797a7bf8668950ab4078fc42eb42d69689` with the
test conflict resolved in place.

## Verification
- `git diff --check origin/backport-to-v5-next-staging..HEAD`
- Strict conflict-marker scan: `rg -n '^(<<<<<<< |=======$|>>>>>>> )'`

Could not run the focused stdlib test locally: `yarn workspace
@aztec/stdlib test src/abi/contract_artifact.test.ts` first failed
because the checkout had no Yarn install state. Preparing that state
required the Noir bootstrap, but `DENOISE=0 ./bootstrap.sh` in `noir/`
failed while trying to install `just@1.42.4` from crates.io due a
tunnel/DNS error. The container also has Rust 1.85.0 while this branch
expects Rust 1.89.0.

---
*Created by
[claudebox](https://claudebox.work/v2/sessions/edfda45656ef1ad6/jobs/1)
· group: `slackbot` · [Slack
thread](https://aztecprotocol.slack.com/archives/C0AGN2WT3CP/p1784820075707329?thread_ts=1784820075.707329&cid=C0AGN2WT3CP)*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v5-next C-noir Component: Noir/Nargo ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants