Simplify eslint configuration and reduce memory consumption - #551
Merged
Conversation
ludamad
approved these changes
May 16, 2023
ludamad
left a comment
ludamad
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once merge is ready
spalladino
force-pushed
the
palla/eslint-memory
branch
from
May 16, 2023 12:46
3442290 to
f628572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current eslint runs were requiring over 8gb of memory allocation to the node process in my machine, and were leading to frequent vs code crashes. After tinkering with the config for a bit, I found that just pointing to the vanilla tsconfig file we're using does the trick, and runs the linter a lot faster. I also added a global lint command that checks the entire project, rather than going into each project sequentially.