AdvantageKit Vision#77
Merged
Merged
Conversation
….md file for slop experiment.
…VisionSystem (and accept some annoying formatter changes)
Contributor
Author
|
Test on robot on Friday prior to going to WPI. |
22 tasks
Contributor
Author
|
We could probably delete the CLAUDE.md prior to merging this, it wasn't actually very helpful. |
Aztechs157-Git
requested changes
May 12, 2026
Contributor
Aztechs157-Git
left a comment
Aztechs157-Git
left a comment
There was a problem hiding this comment.
mostly commenting
| public static double[] cameraStdDevFactors = | ||
| new double[] { | ||
| 1.0, // Camera 0 | ||
| 1.0, // Camera 1 |
Contributor
There was a problem hiding this comment.
use camera names in comments rather than 0, 1 ,2
| @Override | ||
| public void disabledInit() { | ||
| m_robotContainer.visionSystem.updatePoseEstimation(RobotContainer.drive); | ||
| RobotContainer.vision.updateAlliance(); |
Contributor
There was a problem hiding this comment.
If we update in auto and tele init, do we care about updating when we disable?
| public static Drive drive; | ||
| public final Turret turret = new Turret(); | ||
| public final VisionSystem visionSystem; | ||
| // public final VisionSystem visionSystem; |
Aztechs157-Git
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from jank original VisionSystem to new AdvantageKit Vision template, along with other miscellaneous cleanup and an experiment with Claude. Closes #76.