Skip to content

removes db logic to use temp db instead#263

Merged
mjlshen merged 1 commit into
mainfrom
remove-smoke-test-cleanup
Jun 25, 2024
Merged

removes db logic to use temp db instead#263
mjlshen merged 1 commit into
mainfrom
remove-smoke-test-cleanup

Conversation

@tonytheleg

@tonytheleg tonytheleg commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

What this PR does

  • removes all database logic from smoke tests, to instead rely on deploying a temp frontend pointing to a temp DB with standard db container names

Jira:
Link to demo recording:

Special notes for your reviewer

@tonytheleg tonytheleg marked this pull request as draft June 24, 2024 20:56
@tonytheleg tonytheleg force-pushed the remove-smoke-test-cleanup branch from ca52dd6 to 278a057 Compare June 24, 2024 21:55
@tonytheleg tonytheleg changed the title removes clean up call to use temp containers instead removes clean up call to use temp db instead Jun 25, 2024
@tonytheleg tonytheleg marked this pull request as ready for review June 25, 2024 12:00
@tonytheleg tonytheleg changed the title removes clean up call to use temp db instead removes db logic to use temp db instead Jun 25, 2024
@mjlshen mjlshen merged commit 02e9ca9 into main Jun 25, 2024
@mjlshen mjlshen deleted the remove-smoke-test-cleanup branch June 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants