chore: remove GitHub Actions verify workflow, cut over to ci/prow/verify (AROSLSRE-1767) - #317
Conversation
…covers PR checks Prow now runs the verify job for every PR (openshift/release#83080, AROSLSRE-1767). This drops the duplicate GitHub Actions workflow so verify only runs once, via Prow/Tide. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the repository’s native GitHub Actions PR verification workflow (verify) to avoid duplicate CI runs now that the equivalent presubmit is handled by Prow (ci/prow/verify) as part of the repo’s onboarding.
Changes:
- Deletes
.github/workflows/pr.yaml, removing the GitHub Actionsverifyjob previously triggered onpull_requestandmerge_group. - Leaves GitHub Actions workflows in
.github/workflows/limited to non-PR automation (e.g., Dependabot remediation), relying on Prow for PR verification going forward. - Notes an operational follow-up to migrate branch protection required checks from
verifytoci/prow/verify(or Tide) once Prow has reported successfully.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
|
roi (@roivaz): changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga, roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Removes
.github/workflows/pr.yaml(the native GitHub Actionsverifyjob).Why
AROSLSRE-1767 onboarded ARO-Tools onto Prow (see openshift/release#83080). The
ci/prow/verifypresubmit now runs the samemake tidy / lint / testchecks, so the GitHub Actions workflow is redundant. Keeping both means every PR runs the same checks twice.Follow-up
Branch protection's required status check needs to move from
verify(GH Actions) toci/prow/verify(ortide) once this merges and Prow has reported at least once on this PR - otherwise there is a window where no check is required. I'll update branch protection right after this PR shows a greenci/prow/verify.