Skip to content

Added support for Role Definitions and Role Assignments#133

Merged
uday31in merged 17 commits intomainfrom
feature-role-def-assignment
Aug 20, 2020
Merged

Added support for Role Definitions and Role Assignments#133
uday31in merged 17 commits intomainfrom
feature-role-def-assignment

Conversation

@daltondhcp
Copy link
Copy Markdown
Contributor

@daltondhcp daltondhcp commented Aug 18, 2020

  • Support for RoleAssignment and RoleDefinition discovery
  • New target version for Az.Resources (2.4.0) and Az.Accounts (1.9.2)

@daltondhcp daltondhcp requested a review from ljtill as a code owner August 18, 2020 11:16
@daltondhcp daltondhcp requested a review from uday31in August 18, 2020 11:16
@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

uday31in
uday31in previously approved these changes Aug 18, 2020
@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp daltondhcp added the do-not-merge Not ready to merge label Aug 18, 2020
@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp daltondhcp removed the do-not-merge Not ready to merge label Aug 18, 2020
@daltondhcp daltondhcp linked an issue Aug 19, 2020 that may be closed by this pull request
@daltondhcp daltondhcp requested a review from uday31in August 19, 2020 07:43
uday31in
uday31in previously approved these changes Aug 19, 2020
ljtill
ljtill previously approved these changes Aug 19, 2020
@daltondhcp daltondhcp added the do-not-merge Not ready to merge label Aug 19, 2020
@daltondhcp daltondhcp dismissed stale reviews from ljtill and uday31in via 14f8a02 August 20, 2020 08:23
@daltondhcp
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp daltondhcp requested review from ljtill and uday31in August 20, 2020 08:32
@daltondhcp daltondhcp removed the do-not-merge Not ready to merge label Aug 20, 2020
@uday31in uday31in merged commit 0cfacbb into main Aug 20, 2020
@ljtill ljtill added the enhancement New feature or request label Aug 25, 2020
@ljtill ljtill added this to the Release - v0.5 milestone Aug 25, 2020
Makovec added a commit to Makovec/AzOps that referenced this pull request Oct 22, 2020
* Added support for Role Definitions and Role Assignments (Azure#133)

* adding suppport for role definition and assignment

* removing throttling limit

* fixing strict mode bug with roledef

* moving initialiation logic in process

* ensuring return type of an array

* fix count for roledef

* int conversion for env variables

* added validation for aad permissions

* cleanup whitespace

* throtthelimit issue linux

* Updated Az.Resources and Az.Accounts target version

* updated throttlelimit

* Update Get-AzOpsResourceDefinitionAtScope.ps1

* updated serialization for role definitions

* Updated roledefinition schemas

Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>

* Bugfix Skip_Role (Azure#135)

* Bug fix for case sensitive effectiveResourceType (Azure#138)

changing lookup type to case insensitive

* [Feature] Added support for dynamic mg root discovery (Azure#139)

* added support for dynamic partial mg discovery

* update comment

* Adding  Prefix to Az Deployment Name (Azure#140)

* Adding suppot for template deployment without parameter files

* updating test for template deployments

* Adding prefix for deployment name

* Update Invoke-AzOpsGitPush.ps1 (Azure#142)

* Renaming MG, Sub and RG filename to be consistent with other resources (Azure#144)

* Adding suppot for template deployment without parameter files

* updating test for template deployments

* renaming file pattern for MG, Sub and RG

* Handle PastDue subscriptions (Azure#145)

* Roleassignment bugfix (Azure#150)

* convertto-azopsobject fix

* Bugfix - RoleDefinition ordering (Azure#151)

* Handle PastDue subscriptions

* bugfix ordering roledefinition

* Adding support for managed identity for policy effect type modify (Azure#152)

* Adding suppot for template deployment without parameter files

* updating test for template deployments

* Adding support for managed identity for append policy

* Get-AzManagementGroup changes and new target module versions (Azure#154)

* updated targetversions and changed to groupid for get-azmanagementgroup

* roleAssignment exclusion when using AzOpsGeneralizeTemplates (Azure#156)

* handling roleAssignment exclusion

* Fix for uninitialized variable  (Azure#157)

* update

* Bugfix - ensure roleAssignments returned as array (Azure#158)

* Delete azstate.json (Azure#164)

* Update managment group parameter cmdlet (Azure#161)

* Update managment group parameter cmdlet

* New-MG parameter update

Co-authored-by: Lyon Till <158992+ljtill@users.noreply.github.com>

Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
Co-authored-by: uday31in <14359777+uday31in@users.noreply.github.com>
Co-authored-by: Lyon Till <158992+ljtill@users.noreply.github.com>
Co-authored-by: Hansjoerg Scherer <hjscherer@users.noreply.github.com>
@ljtill ljtill removed the enhancement New feature or request label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Role Definitions & Role Assignments

3 participants