Skip to content

Expanded Pester automated integration testing#493

Merged
Jefajers merged 12 commits intoAzure:mainfrom
Jefajers:Pester-IntegrationTest
Dec 29, 2021
Merged

Expanded Pester automated integration testing#493
Jefajers merged 12 commits intoAzure:mainfrom
Jefajers:Pester-IntegrationTest

Conversation

@Jefajers
Copy link
Copy Markdown
Member

@Jefajers Jefajers commented Dec 9, 2021

Overview/Summary

To increase confidence in changes to the codebase this PR adds additional automated tests to validate three pull operations:

  1. Policy assignment at management group scope
  2. Role assignment at subscription scope
  3. Resource deployment at resource group scope

This PR fixes/adds/changes/removes

  1. Adds deployment of a policy assignment
  2. Adds deployment of a role assignment
  3. Adds deployment of a resource deployment
  4. Adds Pester tests to validate resource discovery
  5. Adds logic to remove role assignment at subscription scope for service principal at cleanup
  6. Changes the AzOpsPull operation, it performs a discovery which includes roles, policy's and resources to enable the extended tests
  7. Fixes spelling output

Breaking Changes

N/A

Testing Evidence

Performed a full run of Pester tests resulting in successful deployment and discovery of resources at desired scopes.
Performed a full run of Pester tests resulting in successful deployment and intended failure of resource discovery which the test alerted to for each of the three new scope/types.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers changed the title Update Expanded Pester automated integration testing Dec 9, 2021
@daltondhcp
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Jefajers Jefajers marked this pull request as ready for review December 20, 2021 13:50
@Jefajers Jefajers requested a review from a team as a code owner December 20, 2021 13:50
@daltondhcp
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Jefajers
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Jefajers
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daltondhcp
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Jefajers and others added 2 commits December 28, 2021 14:04
* context

* typo

* update

* plz

* now is the time

* update

* update

* update

Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
@daltondhcp daltondhcp closed this Dec 29, 2021
@daltondhcp daltondhcp reopened this Dec 29, 2021
@Jefajers Jefajers temporarily deployed to test December 29, 2021 10:37 Inactive
Copy link
Copy Markdown
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and🩸 💦 😂 !
🚢

@Jefajers
Copy link
Copy Markdown
Member Author

YOLO

@Jefajers Jefajers merged commit e590819 into Azure:main Dec 29, 2021
@Jefajers Jefajers deleted the Pester-IntegrationTest branch January 5, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants