Skip to content

Enable support for child resources#494

Merged
daltondhcp merged 23 commits intoAzure:mainfrom
SomilGanguly:sogangul-AzOps-AddExtendedChildResources
Jan 13, 2022
Merged

Enable support for child resources#494
daltondhcp merged 23 commits intoAzure:mainfrom
SomilGanguly:sogangul-AzOps-AddExtendedChildResources

Conversation

@SomilGanguly
Copy link
Copy Markdown
Contributor

@SomilGanguly SomilGanguly commented Dec 10, 2021

Overview/Summary

This PR included the new feature - discover child resources based on a flag in settings.

This PR fixes/adds/changes/removes

  1. Adds a new feature to discover child resoruces

Breaking Changes

N?A

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@SomilGanguly SomilGanguly requested a review from a team as a code owner December 10, 2021 07:40
@daltondhcp daltondhcp self-assigned this Dec 10, 2021
@daltondhcp daltondhcp added the do-not-merge Not ready to merge label Dec 10, 2021
@daltondhcp
Copy link
Copy Markdown
Contributor

daltondhcp commented Dec 22, 2021

Awaiting #493 before merging.

daltondhcp
daltondhcp requested changes Dec 29, 2021
View reviewed changes
Comment thread docs/wiki/AzOps-Extended-Child-Resources-Pull.md Outdated
Comment thread docs/wiki/AzOps-Extended-Child-Resources-Pull.md Outdated
Comment thread docs/wiki/Releases.md Outdated
@daltondhcp
Copy link
Copy Markdown
Contributor

daltondhcp commented Dec 29, 2021

Please resolve the conflict in settings.md as well since there are changes added as per #482

@SimonWahlin SimonWahlin mentioned this pull request Dec 30, 2021
Merged
6 tasks
@daltondhcp daltondhcp linked an issue Jan 4, 2022 that may be closed by this pull request
AzOps not pulling ARM templates for child resources? #426
Closed
@daltondhcp daltondhcp changed the title Sogangul az ops add extended child resources Enable support for extended child resources Jan 4, 2022
daltondhcp
daltondhcp reviewed Jan 8, 2022
View reviewed changes
Comment thread src/internal/functions/Get-AzOpsResourceDefinition.ps1 Outdated
@daltondhcp daltondhcp temporarily deployed to test January 8, 2022 15:23 Inactive
@daltondhcp daltondhcp changed the title Enable support for extended child resources Enable support for child resources Jan 12, 2022
@daltondhcp daltondhcp temporarily deployed to test January 12, 2022 17:10 Inactive
@daltondhcp daltondhcp temporarily deployed to test January 13, 2022 10:52 Inactive
daltondhcp
daltondhcp approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@daltondhcp daltondhcp merged commit 34d1a8e into Azure:main Jan 13, 2022
@daltondhcp daltondhcp removed the do-not-merge Not ready to merge label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees

@daltondhcp daltondhcp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AzOps not pulling ARM templates for child resources?

3 participants

@SomilGanguly @daltondhcp @Jefajers