Strider Shield solution#14155
Conversation
|
@microsoft-github-policy-service agree company="NVISO" |
|
Hi @v-shukore , Is there something that should be done from my side? Upon my research regarding failed check, I found that it is a known issue. Kind Regards, Ioannis |
|
Hi @v-shukore , I modified the The issue should be resolved now. Kind Regards, Ioannis |
|
It's a new solution, so I am not sure if the label is correct🙂 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds the new Strider Shield Microsoft Sentinel solution scaffolding, including solution metadata and the solution data manifest, alongside ARM package assets and connector artifacts.
Changes:
- Added
SolutionMetadata.jsondescribing publisher/offer/support metadata for the Strider Shield solution. - Added
Data/Solution_StriderShield.jsonsolution manifest referencing the solution’s connector content. - Added ARM package templates and connector artifacts to support deployment (ignored paths for review per repo rules).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Strider Shield/SolutionMetadata.json | Defines solution marketplace metadata (publisher/offer/support/categories). |
| Solutions/Strider Shield/Package/testParameters.json | Ignored (repo rules: Solutions/**/Package/**). |
| Solutions/Strider Shield/Package/mainTemplate.json | Ignored (repo rules: Solutions/**/Package/**). |
| Solutions/Strider Shield/Package/createUiDefinition.json | Ignored (repo rules: Solutions/**/Package/**). |
| Solutions/Strider Shield/Data/Solution_StriderShield.json | Declares solution package manifest (name/version/paths/metadata reference). |
| Solutions/Strider Shield/Data Connectors/StriderShieldCCF/StriderShield_Table.json | Ignored (repo rules: Solutions/**/Data Connectors/**). |
| Solutions/Strider Shield/Data Connectors/StriderShieldCCF/StriderShield_PollingConfig.json | Ignored (repo rules: Solutions/**/Data Connectors/**). |
| Solutions/Strider Shield/Data Connectors/StriderShieldCCF/StriderShield_DCR.json | Ignored (repo rules: Solutions/**/Data Connectors/**). |
| Solutions/Strider Shield/Data Connectors/StriderShieldCCF/StriderShield_ConnectorDefinition.json | Ignored (repo rules: Solutions/**/Data Connectors/**). |
|
Hi @v-shukore , All copilot suggestions have been resolved. Could you approve the workflow tests? Kind Regards, |
|
Hi @v-shukore , Could we proceed with required review from code owners? Kind Regards, |
|
Hi @v-shukore , Could you approve the workflow tests again? Kind Regards, |
|
Hi @b4k0-nviso, I noticed that the maintemplate is different inside and outside the zip file. It should be the same, so please correct it and commit the change. Thanks. |
…/Azure-Sentinel into StriderShieldSolution
Co-authored-by: Copilot <copilot@github.com>
|
Hi @v-shukore, All changes have been implemented. Could you proceed with related checks and approvals? Kind Regards, |
|
Hi @b4k0-nviso, I checked the zip file for the package, but it isn’t opening and is giving an error. Because of this, I’m unable to test the package. Could you please take a look? Thanks! |
…/Azure-Sentinel into StriderShieldSolution
…/Azure-Sentinel into StriderShieldSolution
|
Hi @v-shukore, All changes have been implemented. Could you proceed with related checks and approvals? Kind Regards, |
|
Hi @b4k0-nviso, please add releasenote.md file for this solution. Thanks! |
|
Hi @v-shukore, I uploaded Please, proceed with your approvals and reviews. Kind Regards, |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed: