Typescript Migration! - #62
Closed
swissarmykirpan wants to merge 15 commits into
Closed
Conversation
swissarmykirpan
commented
Jul 31, 2018
| for (const container of containers) { | ||
| if (container.name === "$logs") { | ||
| for (const entity of entities) { | ||
| if (entity.container.name === "$logs") { |
Author
There was a problem hiding this comment.
attempting to break up a very convoluted object graph
swissarmykirpan
commented
Jul 31, 2018
| const queue = QueueManager.getQueueAndMessage({ | ||
| queueName: request.queueName | ||
| }).queue; | ||
| const queue = QueueManager.getQueueAndMessage(request.queueName).queue; |
Author
There was a problem hiding this comment.
getting ready for types by removing all passing in objects {}
Author
|
There is a lot of room for tests here, going to start adding some as I go through the refactoring process |
Author
|
I have come up with a different strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got started with this, massive piece of work!
Added TSLINT and using Prettier also