Skip to content

Fix: storage container pin#1293

Merged
timotheeguerin merged 4 commits into
masterfrom
fix/container-pin
Apr 19, 2018
Merged

Fix: storage container pin#1293
timotheeguerin merged 4 commits into
masterfrom
fix/container-pin

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #1289

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2018

Codecov Report

Merging #1293 into master will decrease coverage by 0.01%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1293      +/-   ##
=========================================
- Coverage   53.42%   53.4%   -0.02%     
=========================================
  Files         976     976              
  Lines       22772   22780       +8     
  Branches     2564    2565       +1     
=========================================
+ Hits        12165   12166       +1     
- Misses      10607   10614       +7
Impacted Files Coverage Δ
app/services/core/data/storage-entity-getter.ts 28.57% <ø> (ø) ⬆️
app/services/core/data/storage-list-getter.ts 17.39% <ø> (ø) ⬆️
app/services/storage/storage-container.service.ts 13.88% <0%> (-1.04%) ⬇️
app/models/blob-container.ts 66.66% <25%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846915f...4c5bac4. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 3ab3197 into master Apr 19, 2018
@timotheeguerin timotheeguerin deleted the fix/container-pin branch April 19, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix pinning file groups to work with the new path

1 participant