Support quick adding of other output files#423
Merged
Conversation
|
|
||
| it("current task id set", () => { | ||
| const anyComponent = component as any; | ||
| anyComponent = component as any; |
| let anyComponent: any; | ||
|
|
||
| beforeEach(() => { | ||
| anyComponent = component as any; |
Member
There was a problem hiding this comment.
maybe move this to the top beforeEach to have it once only
Member
Author
There was a problem hiding this comment.
yeah i did think of that at the time, got distracted and forgot.
| */ | ||
| private _canAddFileToMap(file: File) { | ||
| return !file.isDirectory && | ||
| !this._fileMap[file.name] && |
Member
There was a problem hiding this comment.
do !(file.name in this._fileMap) here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #184