Skip to content

feat(designer) - Show operation default setting values and host settings in the designer#9253

Merged
Elaina-Lee merged 16 commits into
mainfrom
jmalcampo/nodeSettingDetailsEnhancements
Jun 25, 2026
Merged

feat(designer) - Show operation default setting values and host settings in the designer#9253
Elaina-Lee merged 16 commits into
mainfrom
jmalcampo/nodeSettingDetailsEnhancements

Conversation

@JoaquimMalcampo

@JoaquimMalcampo JoaquimMalcampo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds UI visibility for operation setting defaults returned by the settingDefaults API. Previously, settings like retry policy showed "Default" with no detail fields when no explicit value was set in the workflow definition. Now the designer fetches defaults from the host and displays actual values (e.g., "Exponential interval", count, intervals) while preserving the existing serialization behavior — no changes are written to the workflow JSON.

Additionally, unknown host-level settings returned by the API (e.g., maxMessageBatchSize) are now surfaced in a new read-only "Host settings" section in the settings panel.

Changes

  • settingDefaults.ts - React Query cached fetch for the settingDefaults API endpoint. Applies merge logic for returned setting values and routes additional settings as hostSettings.
  • added defaultHint to SettingData and hostSettings map to Settings interface
  • serializer.ts - if defaultHint is present, does not serialize on retry
  • hostsettings.tsx - dynamic read only section that renders host settings as text fields and is included with the rest of the settings sections in index.tsx
  • operationmanifest.ts (standard/consumption/base) - add getSettingDefaults to operation manifest service interface and implementations.

Impact of Change

  • Users:
    Settings panel now shows actual default values for retry policy and other settings instead of an opaque "Default" label. Host-level read-only settings (e.g., maxMessageBatchSize) are visible in a new collapsible section. No changes to saved workflow definitions.
  • Developers:
    New defaultHint field on SettingData — indicates the value came from API defaults and should not be serialized. hostSettings on Settings is a dynamic Record<string, SettingData> for arbitrary host-returned keys. KNOWN_SETTING_KEYS set in settingDefaults.ts controls which API keys are treated as known vs host-level.
  • System:
    One additional HTTP call per operation during deserialization (cached by React Query). No changes to workflow JSON serialization output.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: VS Code Extension Development Host with Standard Logic App (Service Bus completeQueueMessageV2 operation)

Contributors

Screenshots/Videos

setting_enhancements_part2

Copilot AI review requested due to automatic review settings June 5, 2026 17:09
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(designer) - Show operation default setting values and host settings in the designer
  • Issue: None blocking. The title is descriptive and clearly communicates the change.
  • Recommendation: Optional: remove the double space after the hyphen for polish, e.g. feat(designer) - Show operation default setting values and host settings in the designer.

Commit Type

  • Properly selected (feature).
  • Only one checkbox is selected, which is correct.

Risk Level

  • The selected risk level is Medium, which is consistent with the diff: this change introduces new backend calls, new UI surface area, serialization behavior changes, and feature-flagged behavior. That said, the implementation includes safeguards and tests, so I would keep it at medium rather than raising it.

What & Why

  • Current: Clear and detailed.
  • Issue: None blocking.
  • Recommendation: No required changes. The explanation accurately describes the designer-visible defaults and the new read-only host settings section.

Impact of Change

  • The section is filled out and reflects the affected users, developers, and system behavior.
  • Recommendation:
    • Users: Good as written.
    • Developers: Good as written.
    • System: Good as written.

Test Plan

  • Unit tests are present in the diff, so the test plan passes.
  • Manual testing is also documented, which is a plus.

Contributors

  • Blank, but this is allowed and does not fail the PR.
  • Recommendation: Optional: add contributors if PM/design/review input helped shape the feature.

Screenshots/Videos

  • A screenshot is included, which is appropriate for this UI change.
  • Recommendation: None required.

Summary Table

Section Status Recommendation
Title Optional whitespace cleanup
Commit Type None
Risk Level Keep as Medium
What & Why None
Impact of Change None
Test Plan None
Contributors Optional credit if applicable
Screenshots/Videos None

This PR passes review for title/body compliance. The advised risk level remains Medium, matching the submitter's selection.


Last updated: Thu, 25 Jun 2026 20:15:31 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Designer settings panel to display concrete default operation setting values returned by the backend settingDefaults API (instead of an opaque “Default”), and surfaces unknown host-level settings in a new read-only “Host settings” section—while keeping workflow JSON serialization behavior unchanged.

Changes:

  • Add a React Query–cached settingDefaults fetch + merge path during operation initialization/deserialization.
  • Extend settings types (SettingData, Settings, SettingSectionName) to support read-only/default-hint semantics and host-level settings display.
  • Add a new Settings panel section to render host-level settings as read-only text fields.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Localize/lang/strings.json Adds localization entry for the new “Host settings” section title.
libs/logic-apps-shared/src/designer-client-services/lib/operationmanifest.ts Extends the operation manifest service interface with optional getSettingDefaults.
libs/logic-apps-shared/src/designer-client-services/lib/standard/operationmanifest.ts Implements getSettingDefaults for Standard (including hybrid proxy path).
libs/logic-apps-shared/src/designer-client-services/lib/consumption/operationmanifest.ts Implements getSettingDefaults for Consumption using the existing baseUrl/connectorId URL pattern.
libs/designer/src/lib/ui/settings/sections/hostsettings.tsx New UI section that renders host-level settings as read-only fields.
libs/designer/src/lib/ui/settings/index.tsx Wires the new Host Settings section into the Settings panel and centralizes SettingSectionName.
libs/designer/src/lib/core/state/setting/settingInterface.ts Adds HOSTSETTINGS to the settings section name map.
libs/designer/src/lib/core/queries/settingDefaults.ts Adds supported-settings key extraction, React Query fetch, and merge logic (including hostSettings routing).
libs/designer/src/lib/core/actions/bjsworkflow/settings.ts Extends settings types to support readOnly, defaultHint, and hostSettings.
libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts Avoids serializing retry policy when it was populated from API defaults (via defaultHint).
libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts Fetches and merges setting defaults during manifest-based operation initialization.
libs/designer/src/lib/core/actions/bjsworkflow/add.ts Fetches and merges setting defaults during operation creation/initialization flows.
libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts Adds readOnly to v2 SettingData to keep parity for read-only settings support.

Comment thread libs/designer/src/lib/ui/settings/sections/hostsettings.tsx
Comment thread libs/designer/src/lib/core/queries/settingDefaults.ts
Comment thread libs/designer/src/lib/ui/settings/sections/hostsettings.tsx Outdated
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

⚠️ libs/designer/src/lib/core/queries/settingDefaults.ts - 13% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/ui/settings/sections/hostsettings.tsx - 17% covered (needs improvement)
⚠️ libs/designer/src/lib/ui/settings/sections/hostsettings.tsx - 17% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/operationdeserializer.ts - 17% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/serializer.ts - 37% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts - 17% covered (needs improvement)
⚠️ libs/designer/src/lib/core/actions/bjsworkflow/add.ts - 5% covered (needs improvement)
⚠️ libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts - 4% covered (needs improvement)
⚠️ libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts - 16% covered (needs improvement)
⚠️ libs/designer/src/lib/core/actions/bjsworkflow/settings.ts - 17% covered (needs improvement)
⚠️ libs/logic-apps-shared/src/designer-client-services/lib/consumption/operationmanifest.ts - 75% covered (needs improvement)
⚠️ libs/logic-apps-shared/src/designer-client-services/lib/standard/operationmanifest.ts - 13% covered (needs improvement)

Please add tests for the uncovered files before merging.

@JoaquimMalcampo JoaquimMalcampo changed the title Jmalcampo/node setting details enhancements Show operation default setting values and host settings in the designer Jun 5, 2026
@JoaquimMalcampo JoaquimMalcampo changed the title Show operation default setting values and host settings in the designer feat(designer): Show operation default setting values and host settings in the designer Jun 15, 2026
@JoaquimMalcampo JoaquimMalcampo changed the title feat(designer): Show operation default setting values and host settings in the designer feat(designer) - Show operation default setting values and host settings in the designer Jun 15, 2026
Comment thread libs/designer/src/lib/core/actions/bjsworkflow/add.ts Outdated
Comment thread libs/designer/src/lib/core/queries/settingDefaults.ts Outdated
Comment thread libs/designer/src/lib/core/queries/settingDefaults.ts Outdated
Comment thread libs/designer/src/lib/core/queries/settingDefaults.ts
@andrew-eldridge

Copy link
Copy Markdown
Contributor

some of the copilot comments seem valid

…keyed backend route

HTTP-family built-ins (Http, HttpWebhook, ApiConnection, ApiConnectionWebhook, OpenApiConnection, OpenApiConnectionWebhook) are synthetic on the client and not resolvable through the operationGroups catalog, so the connector route fails backend validation for them. Thread the node operationType through applySettingDefaults and select operationTypes/{operationType}/settingDefaults for these types; all catalog-resolvable operations keep the existing operationGroups route. Skip the fetch entirely for no-retry types (Request, Response, Schedule, DateTime, Compose, control/variable actions).
…n flag

Add enable-operation-setting-defaults experimentation flag and gate applySettingDefaults (v1 + v2) behind it. The feature depends on new backend settingDefaults routes, so it stays off by default and is enabled ring-by-ring as the backend rolls out; the flag doubles as a kill switch. When disabled, no settingDefaults fetch fires (no 404s or log noise). Adds helper + gate tests.
@Elaina-Lee Elaina-Lee merged commit bf48a09 into main Jun 25, 2026
56 of 62 checks passed
@Elaina-Lee Elaina-Lee deleted the jmalcampo/nodeSettingDetailsEnhancements branch June 25, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants