feat(designer) - Show operation default setting values and host settings in the designer#9253
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
This PR passes review for title/body compliance. The advised risk level remains Medium, matching the submitter's selection.Last updated: Thu, 25 Jun 2026 20:15:31 GMT |
There was a problem hiding this comment.
Pull request overview
This PR enhances the Designer settings panel to display concrete default operation setting values returned by the backend settingDefaults API (instead of an opaque “Default”), and surfaces unknown host-level settings in a new read-only “Host settings” section—while keeping workflow JSON serialization behavior unchanged.
Changes:
- Add a React Query–cached
settingDefaultsfetch + merge path during operation initialization/deserialization. - Extend settings types (
SettingData,Settings,SettingSectionName) to support read-only/default-hint semantics and host-level settings display. - Add a new Settings panel section to render host-level settings as read-only text fields.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Localize/lang/strings.json | Adds localization entry for the new “Host settings” section title. |
| libs/logic-apps-shared/src/designer-client-services/lib/operationmanifest.ts | Extends the operation manifest service interface with optional getSettingDefaults. |
| libs/logic-apps-shared/src/designer-client-services/lib/standard/operationmanifest.ts | Implements getSettingDefaults for Standard (including hybrid proxy path). |
| libs/logic-apps-shared/src/designer-client-services/lib/consumption/operationmanifest.ts | Implements getSettingDefaults for Consumption using the existing baseUrl/connectorId URL pattern. |
| libs/designer/src/lib/ui/settings/sections/hostsettings.tsx | New UI section that renders host-level settings as read-only fields. |
| libs/designer/src/lib/ui/settings/index.tsx | Wires the new Host Settings section into the Settings panel and centralizes SettingSectionName. |
| libs/designer/src/lib/core/state/setting/settingInterface.ts | Adds HOSTSETTINGS to the settings section name map. |
| libs/designer/src/lib/core/queries/settingDefaults.ts | Adds supported-settings key extraction, React Query fetch, and merge logic (including hostSettings routing). |
| libs/designer/src/lib/core/actions/bjsworkflow/settings.ts | Extends settings types to support readOnly, defaultHint, and hostSettings. |
| libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts | Avoids serializing retry policy when it was populated from API defaults (via defaultHint). |
| libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts | Fetches and merges setting defaults during manifest-based operation initialization. |
| libs/designer/src/lib/core/actions/bjsworkflow/add.ts | Fetches and merges setting defaults during operation creation/initialization flows. |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts | Adds readOnly to v2 SettingData to keep parity for read-only settings support. |
📊 Coverage CheckThe following changed files need attention:
Please add tests for the uncovered files before merging. |
…thub.com/Azure/LogicAppsUX into jmalcampo/nodeSettingDetailsEnhancements
|
some of the copilot comments seem valid |
…st settings circular import
…derive known keys from settings, log setting-default fetch failures
…keyed backend route
HTTP-family built-ins (Http, HttpWebhook, ApiConnection, ApiConnectionWebhook, OpenApiConnection, OpenApiConnectionWebhook) are synthetic on the client and not resolvable through the operationGroups catalog, so the connector route fails backend validation for them. Thread the node operationType through applySettingDefaults and select operationTypes/{operationType}/settingDefaults for these types; all catalog-resolvable operations keep the existing operationGroups route. Skip the fetch entirely for no-retry types (Request, Response, Schedule, DateTime, Compose, control/variable actions).
…n flag Add enable-operation-setting-defaults experimentation flag and gate applySettingDefaults (v1 + v2) behind it. The feature depends on new backend settingDefaults routes, so it stays off by default and is enabled ring-by-ring as the backend rolls out; the flag doubles as a kill switch. When disabled, no settingDefaults fetch fires (no 404s or log noise). Adds helper + gate tests.
Commit Type
Risk Level
What & Why
Adds UI visibility for operation setting defaults returned by the settingDefaults API. Previously, settings like retry policy showed "Default" with no detail fields when no explicit value was set in the workflow definition. Now the designer fetches defaults from the host and displays actual values (e.g., "Exponential interval", count, intervals) while preserving the existing serialization behavior — no changes are written to the workflow JSON.
Additionally, unknown host-level settings returned by the API (e.g., maxMessageBatchSize) are now surfaced in a new read-only "Host settings" section in the settings panel.
Changes
Impact of Change
Settings panel now shows actual default values for retry policy and other settings instead of an opaque "Default" label. Host-level read-only settings (e.g., maxMessageBatchSize) are visible in a new collapsible section. No changes to saved workflow definitions.
New defaultHint field on SettingData — indicates the value came from API defaults and should not be serialized. hostSettings on Settings is a dynamic Record<string, SettingData> for arbitrary host-returned keys. KNOWN_SETTING_KEYS set in settingDefaults.ts controls which API keys are treated as known vs host-level.
One additional HTTP call per operation during deserialization (cached by React Query). No changes to workflow JSON serialization output.
Test Plan
Contributors
Screenshots/Videos