fix(designer-v2): isolate per-operation init failures so one bad op can't hang the whole load (#9223)

[rllyy97]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

Fixes #9223. In the New Logic Apps experience (DesignerV2), when a single operation-init call fails during workflow load, the entire UI hangs on an infinite spinner. The reported trigger is a Consumption Logic App where a Standard-only API (listMcpServers) returns 400, but the failure is generic: any single per-operation init rejection blocks the whole load.

Root cause: initializeOperationMetadata in operationdeserializer.ts awaited Promise.all(...) over the per-operation init promises. Because Promise.all rejects as soon as any promise rejects, initializeNodes was never dispatched — so no nodes initialized and every node stayed stuck loading. Separately, initializeConnectorOperationDetails in agent.ts was the only init function of its family not wrapped in try/catch, so its getAllConnectors() / getAgentConnectorOperation() calls could reject unguarded.

Changes (scoped to designer-v2):

1. operationdeserializer.ts — Promise.all → Promise.allSettled. A failing operation now marks only that node with a Critical error via updateErrorDetails (and logs through LoggerService), while all healthy nodes still aggregate and initialize normally.
2. agent.ts — wrapped initializeConnectorOperationDetails in try/catch, matching the existing pattern used by its sibling init functions (...ForManagedMcpServer, ...ForManifest, ...ForSwagger).

Scope notes: the equivalent designer v1 code is intentionally left unchanged — this fix targets the New Logic Apps experience (designer-v2) only. The specific listMcpServers bootstrap call that awaits without a catch is Portal-side (different repo); this change removes the entire class of "one failed init hangs the whole load" from the designer-v2 load path, so a 400 (or any rejection) from a single operation no longer blocks the UI.

Impact of Change

• Users: Workflows that previously hung on an infinite spinner in DesignerV2 now load; a failing operation surfaces a node-level error while the rest of the workflow renders normally.
• Developers: initializeOperationMetadata no longer throws on a single per-operation init rejection — failures are isolated per node. initializeConnectorOperationDetails now degrades gracefully instead of rejecting.
• System: No new dependencies. The designer-v2 load path becomes resilient to individual operation-init failures instead of all-or-nothing.

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in:
  • Added agent.spec.ts (3 tests) in designer-v2 covering graceful degradation when connector/operation lookups reject.
  • Unit tests pass: designer-v2 agent 3/3, designer-v2 operationdeserializer 3/3 (existing MCP tests unaffected by the isolation refactor).
  • Biome clean; tsc --noEmit clean on designer-v2.

Contributors

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Screenshots/Videos

N/A

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: fix(designer-v2): isolate per-operation init failures so one bad op can't hang the whole load (#9223)
• Issue: None — this is a clear, specific, and high-quality title.
• Recommendation: No change needed.

---

✅ Commit Type

• Properly selected (fix).
• Only one commit type is checked, which is correct.

---

⚠️ Risk Level

• The selected label/body value is Medium, which is reasonable for a scoped DesignerV2 behavior fix.
• Advised risk level: medium.
• Recommendation: No correction needed. Your risk selection matches the change scope, though the PR also includes a localization strings diff that is unrelated to the main fix and should be double-checked.

---

✅ What & Why

• Current: The section is detailed, explains the root cause, scope, and intended behavior clearly.
• Issue: None — it is more than sufficient.
• Recommendation: No change needed.

---

✅ Impact of Change

• This section is present and gives a meaningful breakdown of user, developer, and system impact.
• Recommendation:
  • Users: Clear and accurate.
  • Developers: Clear and accurate.
  • System: Clear and accurate.

---

✅ Test Plan

• Unit tests are added/updated in the diff, which satisfies the PR test-plan requirement.
• The checkbox state is acceptable because the body also describes the added unit tests and validation.

---

✅ Contributors

• Co-authorship is included, which is good.
• No changes needed.

---

✅ Screenshots/Videos

• Marked N/A, which is appropriate for this non-visual change.

---

Summary Table

Section	Status	Recommendation
Title	✅	No change needed
Commit Type	✅	No change needed
Risk Level	✅	No change needed
What & Why	✅	No change needed
Impact of Change	✅	No change needed
Test Plan	✅	No change needed
Contributors	✅	No change needed
Screenshots/Videos	✅	No change needed

---

Overall: this PR passes the title/body review.

One note: the diff includes Localize/lang/strings.json removals that do not appear to be directly related to the DesignerV2 fix. If those removals were intentional, consider calling them out in the PR body; otherwise, please verify they were not accidental before merging.

---

Last updated: Thu, 02 Jul 2026 16:47:36 GMT

[Copilot]

Pull request overview

This PR fixes a workflow-load hang in the Logic Apps Designer (DesignerV2, mirrored in designer v1) by isolating per-operation initialization failures so a single rejected init promise can’t prevent node initialization for the entire workflow.

Changes:

• Switched per-operation init aggregation from Promise.all to Promise.allSettled and mark only the failed node as Critical via updateErrorDetails.
• Wrapped initializeConnectorOperationDetails in try/catch to prevent unhandled rejections from connector/operation lookup calls.
• Added unit tests validating graceful degradation when connector/operation lookups reject (in both designer and designer-v2).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Localize/lang/strings.json	Prunes unused localized strings (auto-generated by extraction).
libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts	Uses Promise.allSettled to avoid whole-load failure on single operation init rejection; marks failed node with critical error.
libs/designer/src/lib/core/actions/bjsworkflow/agent.ts	Adds guarded error handling + dispatches updateErrorDetails on connector init failures.
libs/designer/src/lib/core/actions/bjsworkflow/test/agent.spec.ts	Adds unit tests for connector init failure scenarios.
libs/designer-v2/src/lib/core/actions/bjsworkflow/operationdeserializer.ts	Same isolation behavior as designer v1 using Promise.allSettled.
libs/designer-v2/src/lib/core/actions/bjsworkflow/agent.ts	Same guarded connector init error handling as designer v1.
libs/designer-v2/src/lib/core/actions/bjsworkflow/test/agent.spec.ts	Same unit tests as designer v1 for connector init failure scenarios.

[github-actions]

📊 Coverage Check

The following changed files need attention:

⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/agent.ts - 26% covered (needs improvement)
⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/operationdeserializer.ts - 16% covered (needs improvement)

Please add tests for the uncovered files before merging.