Skip to content

feat(vscode): Add "Don't show again" for designer version notifications#9362

Merged
andrew-eldridge merged 2 commits into
mainfrom
aeldridge/designerVersionNotification
Jul 2, 2026
Merged

feat(vscode): Add "Don't show again" for designer version notifications#9362
andrew-eldridge merged 2 commits into
mainfrom
aeldridge/designerVersionNotification

Conversation

@andrew-eldridge

@andrew-eldridge andrew-eldridge commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Quality of life improvement, "Don't show again" option will prevent designer version notification (switch from v1->v2 or v2->v1) from showing each time designer is opened.

Impact of Change

  • Users: Adds option to suppress designer version notifications whenever designer is opened
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added the risk:low Low risk change with minimal impact label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(vscode): Add "Don't show again" for designer version notifications
  • Issue: None.
  • Recommendation: No changes needed.

Commit Type

  • Properly selected (feature).
  • Only one commit type is selected, which is correct.

Risk Level

  • The selected label/body risk level is consistent with the change scope, and the repository label includes risk:low.
  • No mismatch found.

What & Why

  • Current: Quality of life improvement, "Don't show again" option will prevent designer version notification (switch from v1->v2 or v2->v1) from showing each time designer is opened.
  • Issue: None; this is clear and concise.
  • Recommendation: No changes needed.

Impact of Change

  • The impact section is sufficiently filled out for this change.
  • Recommendation:
    • Users: Good as written.
    • Developers: N/A is acceptable.
    • System: N/A is acceptable.

Test Plan

  • Unit tests are added/updated in the diff, which satisfies the test plan requirement.
  • Manual testing being checked is fine, but not required for pass since unit tests are present.

Contributors

  • Contributor attribution is present.
  • No action needed.

⚠️ Screenshots/Videos

  • Not provided.
  • This is acceptable if the change is not primarily visual, but if the PR introduces a UI flow change in the designer, adding a screenshot or short video would be helpful for reviewers.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors None
Screenshots/Videos ⚠️ Optional, but helpful for this UI-related change

PR body passes validation. The advised risk level matches the submitted low-risk classification.


Last updated: Thu, 02 Jul 2026 17:44:11 GMT

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

⚠️ apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts - 75% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForAzureResource.ts - 67% covered (needs improvement)

Please add tests for the uncovered files before merging.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user-facing “Don’t show again” option to the VS Code designer version notification so users can suppress the v1↔v2 prompt across designer opens via extension global state.

Changes:

  • Introduces a new globalState key to persist a “suppress designer version notification” preference.
  • Updates the designer-version notification flow to offer “Don’t show again” and persist suppression when selected.
  • Updates unit tests to mock globalState and validate suppression behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/vs-code-designer/src/constants.ts Adds a new exported globalState key constant for suppression.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForLocalProject.ts Removes a now-unnecessary inline comment before calling the notification helper.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForAzureResource.ts Removes a now-unnecessary inline comment before calling the notification helper.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts Adds “Don’t show again” option and persists suppression via ext.context.globalState.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/test/openDesignerForLocalProject.test.ts Extends ext.context test setup to include a mocked globalState.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/test/openDesignerForAzureResource.test.ts Extends ext.context test setup and updates expectation for the additional message option.
apps/vs-code-designer/src/app/commands/workflows/openDesigner/test/openDesignerBase.test.ts Adds globalState mocking and new unit tests covering suppression flows.

Comment thread apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts Outdated
@andrew-eldridge andrew-eldridge merged commit 2c60fcd into main Jul 2, 2026
39 of 40 checks passed
@andrew-eldridge andrew-eldridge deleted the aeldridge/designerVersionNotification branch July 2, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants