fix(vscode): Disable MSI option in connector setup#9364
Merged
Conversation
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | No change needed |
| What & Why | Clarify the wording for readability | |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Optional, but helpful for UI changes |
Overall, this PR passes. The advised risk level matches the submitter’s low-risk selection.
Last updated: Thu, 02 Jul 2026 19:39:56 GMT
Contributor
📊 Coverage Check🎉 All changed files have adequate test coverage! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VS Code “Azure connectors” wizard flow to stop offering Managed Service Identity (MSI) selection during connector setup and instead default authentication to connection keys (rawKeys) while local-authoring MSI support is blocked by #8684.
Changes:
- Update the authentication-method wizard step to auto-default
authenticationMethodtorawKeys(no interactive prompt). - Update/add unit tests to validate the new defaulting behavior and non-overriding behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/vs-code-designer/src/app/commands/workflows/authenticationMethodStep.ts | Forces connector auth selection step to default to rawKeys and skip prompting. |
| apps/vs-code-designer/src/app/commands/workflows/test/authenticationMethodStep.test.ts | Adjusts unit tests to reflect the new non-prompting default behavior. |
lambrianmsft
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Disabling MSI option in azureConnectorWizard setup until #8684 is resolved to support MSI connections in local authoring
Impact of Change
Test Plan
Contributors
@andrew-eldridge