Skip to content

fix(vscode): Disable MSI option in connector setup#9364

Merged
andrew-eldridge merged 1 commit into
mainfrom
aeldridge/disableConnectorMI
Jul 2, 2026
Merged

fix(vscode): Disable MSI option in connector setup#9364
andrew-eldridge merged 1 commit into
mainfrom
aeldridge/disableConnectorMI

Conversation

@andrew-eldridge

@andrew-eldridge andrew-eldridge commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Disabling MSI option in azureConnectorWizard setup until #8684 is resolved to support MSI connections in local authoring

Impact of Change

  • Users: Removes auth type step from azureConnectorWizard flow, now defaults to connection key auth
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added the risk:low Low risk change with minimal impact label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Disable MSI option in connector setup
  • Issue: None — the title is clear, specific, and matches the change.
  • Recommendation: No change needed.

Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

Risk Level

  • The selected label/body risk level is consistent with the small, localized UI/flow change in the diff.
  • Advised risk: low (matches the submitter’s selection).

What & Why

  • Current: Disabling MSI option in azureConnectorWizard setup until #8684 is resolved to support MSI connections in local authoring
  • Issue: Minor wording issue: this reads a bit awkwardly and could be clearer about the actual behavior change.
  • Recommendation: Consider rephrasing to something like: Temporarily disable the MSI option in the Azure connector wizard until #8684 is resolved, and default to connection key auth for local authoring.

Impact of Change

  • The impact section is present and sufficiently describes who is affected.
  • Recommendation:
    • Users: Good — clearly states the auth flow change.
    • Developers: Good — N/A is acceptable here.
    • System: Good — N/A is acceptable here.

Test Plan

  • Unit tests are added/updated in the diff, so the test plan passes.
  • Manual testing is also checked, which is fine.

Contributors

  • Contributor attribution is present (@andrew-eldridge).
  • No change needed.

⚠️ Screenshots/Videos

  • Not provided.
  • If this PR changes a visible wizard flow, adding screenshots would help reviewers verify the UI impact, but this is not required to pass.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level No change needed
What & Why ⚠️ Clarify the wording for readability
Impact of Change No change needed
Test Plan No change needed
Contributors No change needed
Screenshots/Videos ⚠️ Optional, but helpful for UI changes

Overall, this PR passes. The advised risk level matches the submitter’s low-risk selection.


Last updated: Thu, 02 Jul 2026 19:39:56 GMT

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

🎉 All changed files have adequate test coverage!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VS Code “Azure connectors” wizard flow to stop offering Managed Service Identity (MSI) selection during connector setup and instead default authentication to connection keys (rawKeys) while local-authoring MSI support is blocked by #8684.

Changes:

  • Update the authentication-method wizard step to auto-default authenticationMethod to rawKeys (no interactive prompt).
  • Update/add unit tests to validate the new defaulting behavior and non-overriding behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/vs-code-designer/src/app/commands/workflows/authenticationMethodStep.ts Forces connector auth selection step to default to rawKeys and skip prompting.
apps/vs-code-designer/src/app/commands/workflows/test/authenticationMethodStep.test.ts Adjusts unit tests to reflect the new non-prompting default behavior.

@andrew-eldridge andrew-eldridge enabled auto-merge (squash) July 2, 2026 20:46
@andrew-eldridge andrew-eldridge merged commit 78d8ddb into main Jul 2, 2026
47 of 48 checks passed
@andrew-eldridge andrew-eldridge deleted the aeldridge/disableConnectorMI branch July 2, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants