Skip to content

fix(pipeline): remove temp branch pin left over from PR #9453 testing - #9474

Merged
Elaina-Lee merged 1 commit into
mainfrom
elaina/remove-temp-pipeline-ref
Jul 29, 2026
Merged

fix(pipeline): remove temp branch pin left over from PR #9453 testing#9474
Elaina-Lee merged 1 commit into
mainfrom
elaina/remove-temp-pipeline-ref

Conversation

@Elaina-Lee

@Elaina-Lee Elaina-Lee commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

PR #9453 temporarily pinned the LogicAppsUX template repository resource in .azure-pipelines/1esmain.yml to refs/heads/elaina/update-pipeline so test runs would exercise the CFS registry changes in setup.yml. The pin was marked TEMP (testing only, remove before merge) but was accidentally left in when the PR merged. This PR removes the comment block and the ref: line, restoring the pre-#9453 behavior where template references like setup.yml@LogicAppsUX resolve to the default branch (main).

Impact of Change

  • Users: None.
  • Developers: None.
  • System: The 1ES release pipeline resolves its @LogicAppsUX templates from main again instead of the now-merged feature branch. Since elaina/update-pipeline was merged into main, both refs currently have identical template content, so there is no behavior change today — this removes the risk of the pipeline silently drifting or breaking if the feature branch is deleted or diverges.

Test Plan

Contributors

Screenshots/Videos

PR #9453 pinned the LogicAppsUX template repository to
refs/heads/elaina/update-pipeline so test runs would exercise the CFS
changes in setup.yml. That pin was meant to be removed before merge.
Dropping the ref restores the default behavior: template references
like setup.yml@LogicAppsUX resolve to the default branch (main).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01391HTVsUAx7BaUJUvRgVdV
Copilot AI review requested due to automatic review settings July 29, 2026 20:40
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(pipeline): remove temp branch pin left over from PR #9453 testing
  • Issue: None — uses a valid fix(scope): prefix and is clear and descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one type selected (fix), which matches the change (removing an accidentally-merged temporary pin).
  • Note: Good — single type, no overloading.

Risk Level

  • Low is selected in the body and the risk:low label is present, and this matches the advised estimate. The change only removes a temporary ref: pin from an ADO pipeline resource definition (.azure-pipelines/1esmain.yml). It is CI/pipeline automation that does not ship to users, does not touch security/auth, and does not alter repo governance/permissions — correctly low.

What & Why


Impact of Change

  • All three audiences addressed (Users: none, Developers: none, System: 1ES pipeline resolves @LogicAppsUX templates from main again).
  • Recommendation:
    • Users: As stated — none.
    • Developers: As stated — none.
    • System: As stated — clear and accurate.

Test Plan


⚠️ Contributors

  • Section is blank. Not required, but consider crediting any reviewers/PMs who helped identify the leftover pin.

Screenshots/Videos

  • Not required — no UI files (libs/designer-ui/src/, libs/designer/src/, apps/vs-code-react/src/) are touched. This is a pipeline config change only.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level low is correct
What & Why No change needed
Impact of Change No change needed
Test Plan Manual testing justified
Contributors ⚠️ Optionally credit collaborators
Screenshots/Videos N/A — no visual changes

All required checks pass. This PR is compliant and ready to merge. Consider removing the needs-pr-update label.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Wed, 29 Jul 2026 20:43:29 GMT

@Elaina-Lee Elaina-Lee added the risk:low Low risk change with minimal impact label Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Check

No source files changed in this PR.

@Elaina-Lee
Elaina-Lee enabled auto-merge (squash) July 29, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the intended Azure DevOps pipeline behavior by removing a temporary branch pin on the LogicAppsUX GitHub repository resource, so setup.yml@LogicAppsUX templates resolve from the default branch (main) again.

Changes:

  • Remove the temporary comment block and ref: refs/heads/elaina/update-pipeline from the LogicAppsUX repository resource in the 1ES pipeline YAML.

@Elaina-Lee
Elaina-Lee merged commit 3d316f3 into main Jul 29, 2026
20 of 21 checks passed
@Elaina-Lee
Elaina-Lee deleted the elaina/remove-temp-pipeline-ref branch July 29, 2026 21:04
Elaina-Lee added a commit that referenced this pull request Jul 29, 2026
…ck releases (#9476)

revert(pipeline): roll back CFS registry config in setup.yml (#9453)

The CFS registry routing added in #9453 breaks the release pipeline at
the "Install pnpm" step: `npm install -g pnpm` resolves against the CFS
feed and fails with E401 (invalid/missing auth token), so no pipeline
run can get past setup. Roll back setup.yml to its pre-#9453 state to
unblock releases; the SFI/SR21 CFS work can be re-landed once the feed
authentication is sorted out.

The other two files from #9453 stay as they are: the 1esmain.yml branch
pin was already reverted in #9474, and the .npmrc change was only a
trailing-newline fix.


Claude-Session: https://claude.ai/code/session_01391HTVsUAx7BaUJUvRgVdV

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants