test(designer): update Fluent icon snapshot baselines - #9580
Merged
Krrish Mittal (takyyon) merged 1 commit intoAug 28, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Low is correct (test-only) |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | Optionally credit PM/design reviewers | |
| Screenshots/Videos | N/A — no visual product change |
All required checks pass. This is a clean, well-documented test-only snapshot baseline correction — approved.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 27 Aug 2026 22:56:43 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
Updates designer v1 test baselines to reflect the shared Fluent icon mock.
Changes:
- Regenerates 11 affected snapshots using mock icon spans.
- Filters
TimelineHeaderassertions to rendered host elements.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
settings/.../settingsection.spec.tsx.snap |
Updates mocked compound icon. |
settings/.../advancedSettingsMessage.spec.tsx.snap |
Replaces SVG with mock span. |
monitoringTab/.../outputsPanel.spec.tsx.snap |
Updates output-panel icons. |
monitoringTab/.../inputsPanel.spec.tsx.snap |
Updates input-panel icons. |
agentChat/.../agentChatHeader.spec.tsx.snap |
Updates header icons. |
MonitoringTimeline/.../TimelineHeader.test.tsx |
Filters icon matches to host elements. |
MonitoringTimeline/.../TimelineHeader.test.tsx.snap |
Updates timeline header icons. |
MonitoringTimeline/.../TimelineGroup.test.tsx.snap |
Updates group icons. |
MonitoringTimeline/.../TimelineContent.test.tsx.snap |
Updates content icons. |
MonitoringTimeline/.../TimelineButtons.test.tsx.snap |
Updates navigation icons. |
menuItems/.../pinMenuItem.spec.tsx.snap |
Updates pin icons. |
menuItems/.../collapseMenuItem.spec.tsx.snap |
Updates collapse icons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
📊 Coverage CheckNo source files changed in this PR. |
Krrish Mittal (takyyon)
approved these changes
Aug 28, 2026
Krrish Mittal (takyyon)
deleted the
fix-designer-icon-snapshot-baseline
branch
August 28, 2026 00:09
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
#9493 made the shared
@fluentui/react-iconsVitest mock reliably intercept icon imports. Affected icons now render as compact mock spans instead of real inline SVG markup. That PR updated designer UI and designer v2 snapshots, but omitted the equivalent designer v1 baselines.Turbo cache reuse masked the omission because the designer test task could replay a prior result even though its shared test setup had changed. A later fresh execution in #9544 exposed the repository-wide v1 failures: stale snapshots plus a
TimelineHeaderquery that matched both the mocked icon wrapper and its host span.This PR carries only the validated v1 test remediation from #9560: 11 snapshot updates and the
TimelineHeaderhost-element filter. It deliberately excludes the unrelatedquickViewPanelchange and includes no product, Turbo, cache, or workflow changes. The same baseline failure also affected otherwise unrelated work in #9576 and #9579. These links are context only; this PR does not supersede or close those PRs.Impact of Change
Test Plan
@microsoft/logic-apps-designertest:libpassed; forced Turbo designer test executed with 0 cached tasks and passed. The originating remediation also passed coverage in run 33003738944, job 98291904573.Contributors
Screenshots/Videos
Not applicable — this is a test-only snapshot baseline correction with no product UI change.