Skip to content

test(designer): update Fluent icon snapshot baselines - #9580

Merged
Krrish Mittal (takyyon) merged 1 commit into
mainfrom
fix-designer-icon-snapshot-baseline
Aug 28, 2026
Merged

test(designer): update Fluent icon snapshot baselines#9580
Krrish Mittal (takyyon) merged 1 commit into
mainfrom
fix-designer-icon-snapshot-baseline

Conversation

@Elaina-Lee

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

#9493 made the shared @fluentui/react-icons Vitest mock reliably intercept icon imports. Affected icons now render as compact mock spans instead of real inline SVG markup. That PR updated designer UI and designer v2 snapshots, but omitted the equivalent designer v1 baselines.

Turbo cache reuse masked the omission because the designer test task could replay a prior result even though its shared test setup had changed. A later fresh execution in #9544 exposed the repository-wide v1 failures: stale snapshots plus a TimelineHeader query that matched both the mocked icon wrapper and its host span.

This PR carries only the validated v1 test remediation from #9560: 11 snapshot updates and the TimelineHeader host-element filter. It deliberately excludes the unrelated quickViewPanel change and includes no product, Turbo, cache, or workflow changes. The same baseline failure also affected otherwise unrelated work in #9576 and #9579. These links are context only; this PR does not supersede or close those PRs.

Impact of Change

  • Users: None. There are no runtime or user-facing changes.
  • Developers: Restores reliable fresh execution of the designer v1 unit suite after the shared Fluent icon mock change.
  • System: Test files only; no production source, dependencies, architecture, Turbo configuration, or workflows change.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Targeted Biome passed; all 11 affected files passed (68 tests); direct full @microsoft/logic-apps-designer test:lib passed; forced Turbo designer test executed with 0 cached tasks and passed. The originating remediation also passed coverage in run 33003738944, job 98291904573.

Contributors

Screenshots/Videos

Not applicable — this is a test-only snapshot baseline correction with no product UI change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 27, 2026 22:56
@Elaina-Lee Elaina Lee (Elaina-Lee) added the risk:low Low risk change with minimal impact label Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: test(designer): update Fluent icon snapshot baselines
  • Issue: None — uses a valid test: prefix with a (designer) scope and is descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one box selected: test - Test-related changes.
  • Matches the diff, which contains only test files (one .test.tsx and multiple .snap snapshot baselines).

Risk Level

  • Exactly one box selected (Low) and the risk:low label matches the body. This aligns with the advised estimate: the diff is test-only (snapshot baselines + a TimelineHeader host-element filter) with no product source, dependency, Turbo, or workflow changes — no runtime/user impact. Low is correct.

What & Why


Impact of Change

  • All three audiences addressed (Users: none; Developers: restores reliable fresh v1 suite execution; System: test files only).
  • Recommendation:
    • Users: None — no runtime or user-facing changes (as stated).
    • Developers: Reliable fresh execution of the designer v1 unit suite (as stated).
    • System: Test files only; no production/dependency/config changes (as stated).

Test Plan

  • Unit tests updated (checked and confirmed in the diff), with a clear validation note (targeted Biome, 68 tests across 11 files, full test:lib, forced Turbo run with 0 cached tasks). This is a test-only PR, so no additional automated coverage is required.

⚠️ Contributors

  • Contributors listed (@hyehwalee_microsoft, Copilot). Non-blocking — consider crediting any PM/design reviewers if applicable.

⚠️ Screenshots/Videos

  • The diff touches libs/designer/src/ but only test and snapshot files — not a visual product change. No screenshots required; correctly marked "Not applicable."

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Low is correct (test-only)
What & Why No change needed
Impact of Change No change needed
Test Plan No change needed
Contributors ⚠️ Optionally credit PM/design reviewers
Screenshots/Videos ⚠️ N/A — no visual product change

All required checks pass. This is a clean, well-documented test-only snapshot baseline correction — approved.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 27 Aug 2026 22:56:43 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates designer v1 test baselines to reflect the shared Fluent icon mock.

Changes:

  • Regenerates 11 affected snapshots using mock icon spans.
  • Filters TimelineHeader assertions to rendered host elements.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
settings/.../settingsection.spec.tsx.snap Updates mocked compound icon.
settings/.../advancedSettingsMessage.spec.tsx.snap Replaces SVG with mock span.
monitoringTab/.../outputsPanel.spec.tsx.snap Updates output-panel icons.
monitoringTab/.../inputsPanel.spec.tsx.snap Updates input-panel icons.
agentChat/.../agentChatHeader.spec.tsx.snap Updates header icons.
MonitoringTimeline/.../TimelineHeader.test.tsx Filters icon matches to host elements.
MonitoringTimeline/.../TimelineHeader.test.tsx.snap Updates timeline header icons.
MonitoringTimeline/.../TimelineGroup.test.tsx.snap Updates group icons.
MonitoringTimeline/.../TimelineContent.test.tsx.snap Updates content icons.
MonitoringTimeline/.../TimelineButtons.test.tsx.snap Updates navigation icons.
menuItems/.../pinMenuItem.spec.tsx.snap Updates pin icons.
menuItems/.../collapseMenuItem.spec.tsx.snap Updates collapse icons.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Check

No source files changed in this PR.

@takyyon
Krrish Mittal (takyyon) merged commit 4b7ffb5 into main Aug 28, 2026
68 of 79 checks passed
@takyyon
Krrish Mittal (takyyon) deleted the fix-designer-icon-snapshot-baseline branch August 28, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants