fix(designer): apply disabled styling to Reassign - #9600
Merged
Brian Lam (lambrianmsft) merged 1 commit intoSep 4, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Brian Lam (lambrianmsft)
September 3, 2026 21:43
View session
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Low is correct and matches label |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | Unit tests present |
| Contributors | Optionally credit collaborators | |
| Screenshots/Videos | ✅ | Provided |
All required checks pass — this PR is compliant and good to merge. 🎉
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Fri, 04 Sep 2026 17:15:50 GMT
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The visual UI change lacks the screenshots required for changes under libs/designer/src/.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes disabled Reassign styling consistently across both designer implementations.
Changes:
- Removes the brand-color override in read-only mode.
- Adds focused unit assertions for disabled styling.
File summaries
| File | Description |
|---|---|
libs/designer/.../connectionEntry.tsx |
Applies disabled styling correctly. |
libs/designer/.../connectionEntry.spec.tsx |
Tests removal of inline styling. |
libs/designer-v2/.../connectionEntry.tsx |
Mirrors the styling fix in V2. |
libs/designer-v2/.../connectionEntry.spec.tsx |
Tests the V2 disabled state. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Krrish Mittal (takyyon)
approved these changes
Sep 4, 2026
Carlos Castro Trejo (ccastrotrejo)
approved these changes
Sep 4, 2026
Carlos Castro Trejo (ccastrotrejo)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Both the original and V2 Connections panels disabled Reassign in read-only mode, but an inline brand-color override kept the action text blue. This removes that override for disabled actions so Fluent renders the entire Reassign action, including its text, with the proper disabled styling.
Impact of Change
Test Plan
Contributors
Screenshots/Videos
Read only has the text disabled as well
