[Fixes] VM - Update NIC IP Address handover

[chris5287]

Description

Fixes #1676

The ipConfiguration.vmIPAddress property within the Virtual Machine module is sent via a nested bicep resource to the Network Interfaces module using privateIPAddress, instead of vmIPAddress

I would assume we cannot update the Network Intefaces modules to align to the privateIPAddress property (as that would be a break public interface, so I guess the fix is to map the Virtual Machine nested bicep to use vmIPAddress throughout.

1st nested layer:

ResourceModules/modules/Microsoft.Compute/virtualMachines/.bicep/nested_networkInterface.bicep

Line 68 in be70744

privateIPAddress: contains(ipConfiguration, 'vmIPAddress') ? (!empty(ipConfiguration.vmIPAddress) ? ipConfiguration.vmIPAddress : null) : null

2nd nested layer:

ResourceModules/modules/Microsoft.Network/networkInterfaces/deploy.bicep

Line 107 in be70744

privateIPAddress: contains(ipConfiguration, 'vmIPAddress') ? (!empty(ipConfiguration.vmIPAddress) ? ipConfiguration.vmIPAddress : null) : null

To reproduce

Example Bicep module call below

module vm 'main/modules/Microsoft.Compute/virtualMachines/deploy.bicep' = {
  name: '${deployment().name}_vm'
  params: {
    name: 'name'
    imageReference: {
      publisher: 'zscaler'
      offer: 'zscaler-private-access'
      sku: 'zpa-con-azure'
      version: 'latest'
    }
    vmSize: 'Standard_D4s_v3'
    adminUsername: 'azure-username'
    adminPassword: 'supersecretpassword'
    osType: 'Linux'
    osDisk: {
      diskSizeGB: '16'
      managedDisk: {
        storageAccountType: 'StandardSSD_LRS'
      }
    }
    nicConfigurations: [
      {
        nicSuffix: '-nic-01'
        enableAcceleratedNetworking: true
        ipConfigurations: [
          {
            name: 'ipconfig01'
            subnetId: '/subscriptions/...../subnets/....'
            privateIPAllocationMethod: 'Static'
            vmIPAddress: '192.168.10.10'
          }
        ]
      }
    ]
  }
}

Type of Change

Please delete options that are not relevant.

• Bugfix (non-breaking change which fixes an issue)

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (readme)
• I did format my code

[ghost]

All CLA requirements met.

[AlexanderSehr]

Thank you for your contribution @chris5287