Skip to content

[Modules] NIC: Updated subnetID to subnetResourceId for consistency#1684

Merged
AlexanderSehr merged 2 commits into
mainfrom
users/alsehr/nicPropertyName
Jul 18, 2022
Merged

[Modules] NIC: Updated subnetID to subnetResourceId for consistency#1684
AlexanderSehr merged 2 commits into
mainfrom
users/alsehr/nicPropertyName

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jul 17, 2022

Description

  • Updated subnetID to subnetResourceId for consistency

Follow-up to #1677

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines
Network: NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 17, 2022 16:37
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jul 17, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2022

Unit Test Results

  1 files  ±0    1 suites  ±0   45s ⏱️ -3s
81 tests ±0  80 ✔️ +1  1 💤 ±0  0  - 1 
86 runs  ±0  85 ✔️ +1  1 💤 ±0  0  - 1 

Results for commit 7be30bd. ± Comparison against base commit 6f10dd1.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 17, 2022 16:40
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 5a2e2de into main Jul 18, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/nicPropertyName branch July 18, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Cannot deploy Virtual Machine with Static IP Address

2 participants