Skip to content

[Modules] Updated Network Interface module API Version#1722

Merged
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/nicUpdates
Jul 29, 2022
Merged

[Modules] Updated Network Interface module API Version#1722
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/nicUpdates

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla commented Jul 29, 2022 •
edited
Loading

closes #1718

Description

  • Updated nic module API version and documentation.
  • Updated VM documentation for the new nic api version

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkInterfaces
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla requested a review from a team as a code owner July 29, 2022 07:29
@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules [prio] high importance of the issue: high priority labels Jul 29, 2022
@ahmadabdalla ahmadabdalla added this to the Release 0.7 milestone Jul 29, 2022
@ahmadabdalla ahmadabdalla mentioned this pull request Jul 29, 2022
Merged
10 tasks
@eriqua eriqua changed the title Updated Network Interface module API Version [Modules] Updated Network Interface module API Version Jul 29, 2022
eriqua
eriqua approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit d3738f6 into main Jul 29, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/nicUpdates branch July 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels

bug Something isn't working [cat] modules category: modules [prio] high importance of the issue: high priority

Projects

Backlog
Status: Done

Milestone

Release 0.7

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Network Interface module version needs to be uplifted for other resources that use it to run successfully

2 participants

@ahmadabdalla @eriqua