[DC/OS] Add support for DCOS 1.9 EA#360
Conversation
|
@wbuchwalter, |
|
Can one of the admins verify this patch? |
|
I have added some documentation to help for future releases, would be great if someone that already went through the process could review it (and tell me if there is an easier way 😃) |
|
Can one of the admins verify this patch? |
|
@anhowe @colemickens Do you have any tips to debug a DC/OS deployment? |
|
Being stuck on /waitforleader means that the basic DCOS services are not coming up. This usually points to the fact that the import of custom data, or guid specification was wrong. To troubleshoot this, I first:
|
|
This PR is ready for review. |
| var files []string | ||
| var baseFile string | ||
| if properties.OrchestratorProfile.OrchestratorType == api.DCOS188 || | ||
| properties.OrchestratorProfile.OrchestratorType == api.DCOS190 || |
There was a problem hiding this comment.
@wbuchwalter , can you also update "if strings.HasPrefix" condition (~line 359) for default "case api.DCOS" to be DCOS190 URL?
There was a problem hiding this comment.
@amanohar Since 1.9 isn't GA yet, I was thinking of letting 1.8.8 as default version so that PR can still be merged, and making another PR once 1.9 hit GA since the bootstrap url will also change from EarlyAccess to Stable and the package ids will be differents.
Let me know what you think.
|
So that new NAT rule isn't needed. We can still ssh on the same ports as 1.8.8 without it. Now we might want it so that we can ssh to port 22 on the load balancer. I was surprised that your change was different from what is in the dcos repo. You made a loop on master count instead of just a single resource to do this. |
|
@JackQuincy Thanks! I removed the loop that was a mistake indeed. |
|
Is this working? DCOS 1.9 has some amazing features, and we'd like to be able to use it. |
|
@macalinao Yes it is working. If you find bug/issues with this PR please let us know. |
|
@wbuchwalter - Please refresh to latest 1.9, and refresh build |
|
@anhowe done |
JackQuincy
left a comment
JackQuincy
left a comment
There was a problem hiding this comment.
two little changes other than that lgtm
| // DCOS is the string constant for DCOS orchestrator type and defaults to DCOS188 | ||
| DCOS OrchestratorType = "DCOS" | ||
| // DCOS187 is the string constant for DCOS 1.8.8 orchestrator type | ||
| // DCOS190 is the string constant for DCOS 1.8.8 orchestrator type |
| const ( | ||
| // DCOS is the string constant for DCOS orchestrator type and defaults to DCOS188 | ||
| DCOS = "DCOS" | ||
| // DCOS190 is the string constant for DCOS 1.8.8 orchestrator type |
7 participants
Addresses issue #359.
This change is