Skip to content

app: Revert electron-builder version bump - #332

Merged
René Dudfield (illume) merged 1 commit into
Azure:headlamp-downstreamfrom
sniok:revert-electron-builder
Feb 26, 2026
Merged

app: Revert electron-builder version bump#332
René Dudfield (illume) merged 1 commit into
Azure:headlamp-downstreamfrom
sniok:revert-electron-builder

Conversation

@sniok

Copy link
Copy Markdown
Collaborator

this pr reverts electron-builder version bump and build configuration

Copilot AI review requested due to automatic review settings February 26, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts the electron-builder package from version 26.6.0 back to version 24.13.3, along with reverting associated build configuration changes. The primary motivation appears to be addressing compatibility or build issues introduced by the newer version.

Changes:

  • Downgraded electron-builder from ^26.6.0 to ^24.13.3
  • Reverted Windows signing configuration from nested signtoolOptions.sign structure to direct sign property
  • Updated package-lock.json with all transitive dependencies matching the older electron-builder version

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
app/package.json Reverted electron-builder version and Windows signing configuration format
app/package-lock.json Updated dependency tree to match electron-builder v24.13.3 and its transitive dependencies

The changes are internally consistent - the signing configuration change from signtoolOptions: { sign: "windows/sign.js" } to sign: "windows/sign.js" aligns with the API differences between electron-builder v26 and v24. The referenced windows/sign.js file exists and is properly implemented.

The package-lock.json shows a clean reversion with:

  • Removal of newer dependencies introduced by v26 (e.g., @electron/rebuild, @electron/fuses, node-gyp v11)
  • Restoration of older dependency versions compatible with v24
  • Addition of dependencies that v24 requires (e.g., bluebird-lst, form-data in electron-publish)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@illume René Dudfield (illume) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@illume

Copy link
Copy Markdown
Collaborator

Frontend failures are fixed in another PR.

@illume
René Dudfield (illume) merged commit 56b499d into Azure:headlamp-downstream Feb 26, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants