Skip to content

aksd: Remove azure format from get-credentials - #343

Merged
S Santhosh Nagaraj (yolossn) merged 1 commit into
Azure:headlamp-downstreamfrom
yolossn:fix_custom_exec
Feb 27, 2026
Merged

aksd: Remove azure format from get-credentials#343
S Santhosh Nagaraj (yolossn) merged 1 commit into
Azure:headlamp-downstreamfrom
yolossn:fix_custom_exec

Conversation

@yolossn

@yolossn S Santhosh Nagaraj (yolossn) commented Feb 27, 2026

Copy link
Copy Markdown
Member

Description

Removes "--format azure" from "az aks get-credentials" to allow
kubeconfig generation compatible with the custom kubelogin
conversion step.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • CI/CD changes
  • Other: **___**

Related Issues

Closes #342

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes AKS cluster registration for Azure RBAC clusters by adjusting the az aks get-credentials invocation so the produced kubeconfig can be correctly converted to the app’s exec-based auth flow.

Changes:

  • Removes --format azure from az aks get-credentials to allow kubeconfig generation compatible with the kubelogin conversion step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/electron/aks-cluster.ts
Comment thread app/electron/aks-cluster.ts
Removes "--format azure" from "az aks get-credentials"
to allow kubeconfig generation compatible with the
custom kubelogin conversion step.

Signed-off-by: yolossn <sannagaraj@microsoft.com>
@yolossn
S Santhosh Nagaraj (yolossn) merged commit e182e85 into Azure:headlamp-downstream Feb 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants