Skip to content

Fix 'PessimisticConcurrencyConflict' next to 'Conflict' error codes #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Fix 'PessimisticConcurrencyConflict' next to 'Conflict' error codes #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/code/common/Http.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ private static bool ShouldRetryInner(HttpMessage message, Exception? exception)
(message, exception) switch
{
({ Response.Status: 422 or 409 }, _) when HasManagementApiRequestFailedError(message.Response) => true,
({ Response.Status: 409 }, _) when HasConflictError(message.Response) && HasOperationOnTheApiIsInProgressMessage(message.Response) => true,
({ Response.Status: 409 }, _) when HasConflictOrPessimisticConcurrencyConflictError(message.Response) && HasOperationOnTheApiIsInProgressMessage(message.Response) => true,
({ Response.Status: 412 }, _) => true,
({ Response.Status: 429 }, _) => true,
_ => false
Expand All @@ -419,9 +419,12 @@ private static bool HasManagementApiRequestFailedError(Response response) =>
.Where(code => code.Equals("ManagementApiRequestFailed", StringComparison.OrdinalIgnoreCase))
.IsSome;

private static bool HasConflictError(Response response) =>
private static bool HasConflictOrPessimisticConcurrencyConflictError(Response response) =>
TryGetErrorCode(response)
.Where(code => code.Equals("Conflict", StringComparison.OrdinalIgnoreCase))
.Where(code =>
code.Equals("Conflict", StringComparison.OrdinalIgnoreCase) ||
code.Equals("PessimisticConcurrencyConflict", StringComparison.OrdinalIgnoreCase)
)
.IsSome;

private static bool HasOperationOnTheApiIsInProgressMessage(Response response) =>
Expand Down