Skip to content

Conversation

@LockTar
Copy link
Contributor

@LockTar LockTar commented Nov 17, 2025

In PR 787 we added a retry for 409 conflict errors.
We now get almost the same error so I added an "or" statement.

We get the following error:
{"error":{"code":"PessimisticConcurrencyConflict","message":"Operation on the API is in progress","details":null}}

This pull request updates the HTTP retry logic to handle an additional error scenario related to concurrency conflicts. The main focus is on improving the robustness of retry decisions when a 409 response status is encountered.

Improvements to error handling and retry logic:

  • The helper method previously named HasConflictError has been renamed to HasConflictOrPessimisticConcurrencyConflictError, and its logic expanded to check for both Conflict and PessimisticConcurrencyConflict error codes in the response.

…cConcurrencyConflictError` to reflect its expanded functionality. This method now checks for both `Conflict` and `PessimisticConcurrencyConflict` error codes.
@waelkdouh
Copy link
Contributor

Hi. Thank you for your PR. We are currently working on releasing a V7 so is there anyway you can make your changes against the V7 feature branch as we have introduced some good changes.

@LockTar
Copy link
Contributor Author

LockTar commented Nov 17, 2025

Hi. Thank you for your PR. We are currently working on releasing a V7 so is there anyway you can make your changes against the V7 feature branch as we have introduced some good changes.

Sure! No problem to do the change on the v7 as well.
But can you please approve this on the v6 as well? We are unable to deploy our apis at the moment.
Thanks!

@LockTar
Copy link
Contributor Author

LockTar commented Nov 17, 2025

@waelkdouh I implemented the fix in v7 as well with #800.

I hope you have some time to merge and release this PR because we are unable to deploy apis.

@waelkdouh
Copy link
Contributor

I will let @guythetechie decide on this.

@guythetechie
Copy link
Contributor

Let's merge this PR in v6. I'll make the necessary changes to v7.

@waelkdouh waelkdouh merged commit 35a0fdd into Azure:main Nov 17, 2025
1 check passed
@waelkdouh
Copy link
Contributor

@LockTar thank you for your PR! I went ahead and merged. I will release shortly. Be on the lookout. As we mentioned above @guythetechie will take care of making the necessary changes for v7 and merge accordingly.

@waelkdouh
Copy link
Contributor

@LockTar check v6.0.2 which includes your fixes. Please let us know when you get a chance to extensively test it.

@LockTar LockTar deleted the f/fix-409-PessimisticConcurrencyConflict-error branch November 17, 2025 15:45
@LockTar
Copy link
Contributor Author

LockTar commented Nov 25, 2025

@waelkdouh we tested the fix now multiple times and we don't get the error anymore! So the fix works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants