Skip to content

v7 Add enhanced retry logic for HTTP 409 conflict errors #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

v7 Add enhanced retry logic for HTTP 409 conflict errors #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tools/code/common/Http.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ private static bool ShouldRetryInner(HttpMessage message, Exception? exception)
(message, exception) switch
{
({ Response.Status: 422 or 409 }, _) when HasManagementApiRequestFailedError(message.Response) => true,
({ Response.Status: 409 }, _) when HasConflictOrPessimisticConcurrencyConflictError(message.Response) && HasOperationOnTheApiIsInProgressMessage(message.Response) => true,
({ Response.Status: 412 }, _) => true,
({ Response.Status: 429 }, _) => true,
_ => false
Expand All @@ -418,6 +419,19 @@ private static bool HasManagementApiRequestFailedError(Response response) =>
.Where(code => code.Equals("ManagementApiRequestFailed", StringComparison.OrdinalIgnoreCase))
.IsSome;

private static bool HasConflictOrPessimisticConcurrencyConflictError(Response response) =>
TryGetErrorCode(response)
.Where(code =>
code.Equals("Conflict", StringComparison.OrdinalIgnoreCase) ||
code.Equals("PessimisticConcurrencyConflict", StringComparison.OrdinalIgnoreCase)
)
.IsSome;

private static bool HasOperationOnTheApiIsInProgressMessage(Response response) =>
TryGetMessage(response)
.Where(code => code.Equals("Operation on the API is in progress", StringComparison.OrdinalIgnoreCase))
.IsSome;

private static Option<string> TryGetErrorCode(Response response)
{
try
Expand All @@ -433,6 +447,22 @@ private static Option<string> TryGetErrorCode(Response response)
return Option<string>.None;
}
}

private static Option<string> TryGetMessage(Response response)
{
try
{
return response.Content
.ToObjectFromJson<JsonObject>()
.TryGetJsonObjectProperty("error")
.Bind(error => error.TryGetStringProperty("message"))
.ToOption();
}
catch (Exception exception) when (exception is ArgumentNullException or NotSupportedException or JsonException)
{
return Option<string>.None;
}
}
}

public class TelemetryPolicy(Version version) : HttpPipelinePolicy
Expand Down