v7 Add enhanced retry logic for HTTP 409 conflict errors #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the retry logic to handle HTTP 409 responses more robustly by checking for specific error codes ("Conflict" or "PessimisticConcurrencyConflict") and messages ("Operation on the API is in progress").
Added `HasConflictOrPessimisticConcurrencyConflictError` and `HasOperationOnTheApiIsInProgressMessage` helper methods to encapsulate these checks. Introduced `TryGetMessage` to safely extract the "message" property from JSON responses, with improved error handling for parsing failures.
Refactored code to improve readability and maintainability by modularizing retry condition checks.
Contributor
|
Closing in favor of 5ba67d3, which aligns more with v7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR 787 for v6 we added retry logic for Conflict error. That PR is apparantly not merged to v7 but was also not sufficient because of the missing
PessimisticConcurrencyConflicterror. See PR 799 for more information for the v6 implementation.Details:
Enhanced the retry logic to handle HTTP 409 responses more robustly by checking for specific error codes ("Conflict" or "PessimisticConcurrencyConflict") and messages ("Operation on the API is in progress").
Added
HasConflictOrPessimisticConcurrencyConflictErrorandHasOperationOnTheApiIsInProgressMessagehelper methods to encapsulate these checks. IntroducedTryGetMessageto safely extract the "message" property from JSON responses, with improved error handling for parsing failures.Refactored code to improve readability and maintainability by modularizing retry condition checks.