Preserve API overrides during spec publish by reusing publisher DTO#862
Open
ametelski wants to merge 2 commits into
Open
Preserve API overrides during spec publish by reusing publisher DTO#862ametelski wants to merge 2 commits into
ametelski wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When publishing an API with a spec file, ApiOps performs two updates: first it PUTs the API DTO (including publisher overrides), then it PUTs the specification payload. The bug is that the spec PUT path was rebuilding its payload from a fresh APIM GET response, and that response can omit fields like translateRequiredQueryParameters. As a result, override values applied in the first PUT could be dropped in the second PUT, causing APIM to fall back to default behavior (e.g., required query params treated as path templates, leading to unexpected 404s instead of 400s).
The fix is to reuse the already-resolved publisher DTO as the base for spec publishing, then merge only spec-specific fields (format and value). This preserves override-controlled properties across both PUTs and keeps API behavior deterministic.
Closes #860