Skip to content

Conversation

@chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Mar 10, 2023

Description

Fix #3196
Fix #3183

  • upgrade typespec libraries to 0.41.0
  • rename dotnet emitter to @azure-tools/typespec-csharp

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@chunyu3 chunyu3 marked this pull request as draft March 10, 2023 02:53
@chunyu3 chunyu3 added the DPG label Mar 10, 2023
@chunyu3 chunyu3 marked this pull request as ready for review March 10, 2023 08:43
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to rename files also in this PR?
CadlGenerate.ps1 =>typespecGenerate.ps1

Co-authored-by: Renhe Li <renhe.li@hotmail.com>
@chunyu3 chunyu3 requested review from lirenhe and pshao25 March 14, 2023 05:30
@lirenhe
Copy link
Member

lirenhe commented Mar 14, 2023

@chunyu3 Could you share the result of the SDK repo regen?
Any other failures besides OpenAI and MVAD?

@chunyu3
Copy link
Member Author

chunyu3 commented Mar 15, 2023

@chunyu3 Could you share the result of the SDK repo regen? Any other failures besides OpenAI and MVAD?

Yes. I regened the sdk repo. There is no changes except failure on cadl dpg project OpenAI and MVAD.

@chunyu3 chunyu3 enabled auto-merge (squash) March 15, 2023 02:14
@chunyu3 chunyu3 disabled auto-merge March 15, 2023 09:33
@chunyu3
Copy link
Member Author

chunyu3 commented Mar 16, 2023

regen azure-sdk-for-net, regen branch: https://github.com/chunyu3/azure-sdk-for-net/tree/typespecRenaming, no sdk change.

@lirenhe
Copy link
Member

lirenhe commented Mar 16, 2023

The rest of rename (file/folder, cadl.json etc )could be happen in another PR. Approve this one to unblock the migration effort.

@chunyu3 chunyu3 merged commit 68d87b3 into Azure:feature/v3 Mar 16, 2023
@chunyu3 chunyu3 deleted the typespecRenaming branch July 12, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TypeSpec to 0.41 Rename dotnet emitter

3 participants