AADDSscenario says Entra ID joined but joins domain controller

[mloskot]

Let us know the feedback or general question

The AADDSscenario/readme.md says:

This scenario deploys a new Azure Virtual Desktop workload with Microsoft Entra ID joined session host

while in the code it makes use of the JsonADDomainExtensions for a regular domain join:

avdaccelerator/workload/terraform/greenfield/AADDSscenario/host.tf

Lines 65 to 82 in c6e1386

	resource "azurerm_virtual_machine_extension" "aaddsjoin" {
	count = var.rdsh_count
	name = "${var.prefix}-${count.index + 1}-aaddsJoin"
	virtual_machine_id = azurerm_windows_virtual_machine.avd_vm.*.id[count.index]
	publisher = "Microsoft.Compute"
	type = "JsonADDomainExtensions"
	type_handler_version = "1.3"
	auto_upgrade_minor_version = true
	settings = <<-SETTINGS
	{
	"Name": "${azurerm_active_directory_domain_service.aadds.domain_name}",
	"OUPath": "${var.avd_ou_path}",
	"User": "${azuread_user.dc_admin.user_principal_name}",
	"Restart": "true",
	"Options": "3"
	}
	SETTINGS

If this scenario was creating Entra ID joined VM-s, should shouldn't it rather setup the VM extension AADLoginForWindows , as after https://learn.microsoft.com/en-us/entra/identity/devices/howto-vm-sign-in-azure-ad-windows:

The AADLoginForWindows extension must be installed successfully for the VM to complete the Microsoft Entra join process.

and

After you enable this capability, your Windows VMs in Azure will be Microsoft Entra joined. You cannot join them to another domain, like on-premises Active Directory or Microsoft Entra Domain Services.

I believe there exists the confusion caused by describing "Entra ID join" while performing a domain join.

[danycontre]

Mateusz Łoskot (@mloskot) thanks for your feedback, readme was updated to reference Microsoft Entra Domain Services, the scenario is meant to join session host to Microsoft Entra Domain Services domain controllers not to Microsoft Entra ID.

[mloskot]

Dany Contreras (@danycontre) I see. Thank you!