[Mysql] az mysql flexible-server create/update: Add --accelerated-logs to support configuring accelerated logs for Business Critical tier - #29936
Merged
Yishi Wang (evelyn-ys) merged 6 commits intoSep 23, 2024
Conversation
️✔️AzureCLI-FullTest
|
|
Hi linyudoa, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server create | cmd mysql flexible-server create added parameter accelerated_logs |
||
| mysql flexible-server geo-restore | cmd mysql flexible-server geo-restore added parameter accelerated_logs |
||
| mysql flexible-server restore | cmd mysql flexible-server restore added parameter accelerated_logs |
||
| mysql flexible-server update | cmd mysql flexible-server update added parameter accelerated_logs |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
the
customer-reported
linyudoa
changed the title
linyudoa
changed the title
Haoran Hong (honghr)
approved these changes
Sep 23, 2024
| instance.storage.auto_grow = auto_grow | ||
|
|
||
| if accelerated_logs: | ||
| instance.storage.log_on_disk = accelerated_logs |
Contributor
There was a problem hiding this comment.
We need validate accelerated_logs before execute update call.
Yishi Wang (evelyn-ys)
approved these changes
Sep 23, 2024
Yishi Wang (evelyn-ys)
changed the title
az mysql flexible-server create/update: Add --accelerated-logs to support configuring accelerated logs for Business Critical tier
Contributor
|
It's not good practice to leave all the PR description as empty. Also the PR title needs to be formatted. |
Julius Liu (juliusl)
pushed a commit
to juliusl/azure-cli
that referenced
this pull request
Sep 23, 2024
…logs` to support configuring accelerated logs for Business Critical tier (Azure#29936) * complete code for review * Update _validators.py * update test file * fix lint * Update custom.py * Update custom.py
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.