[AKS] Add --enable-hosted-system, --system-node-subnet-id and --node-subnet-id to az aks update - #33928
[AKS] Add --enable-hosted-system, --system-node-subnet-id and --node-subnet-id to az aks update#33928reneeli123 wants to merge 5 commits into
--enable-hosted-system, --system-node-subnet-id and --node-subnet-id to az aks update#33928Conversation
|
Hi reneeli123, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Adds support for converting an existing AKS Automatic cluster to a Managed System Pool (hosted system / “HOBO”) cluster via az aks update, bringing the update path closer to feature parity with az aks create for hosted-system conversion and optional BYO VNet subnet inputs.
Changes:
- Adds
--enable-hosted-system,--system-node-subnet-id, and--node-subnet-idtoaz aks update(params + command signature + help). - Extends hosted-system enablement + subnet validation to run in UPDATE mode, and adds
update_hosted_system_profile()to sethostedSystemProfileduring update. - Adds unit tests for the new update behavior and linter exclusions for the new parameters.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py | Adds unit tests covering hosted-system profile updates and validation on aks update. |
| src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py | Enables hosted-system validation in UPDATE mode and adds update_hosted_system_profile() to populate hostedSystemProfile during update. |
| src/azure-cli/azure/cli/command_modules/acs/linter_exclusions.yml | Excludes missing parameter test coverage lints for the new aks update parameters. |
| src/azure-cli/azure/cli/command_modules/acs/custom.py | Adds new arguments to the aks_update command function signature. |
| src/azure-cli/azure/cli/command_modules/acs/_params.py | Wires new CLI arguments (with validators / store_true) into aks update. |
| src/azure-cli/azure/cli/command_modules/acs/_help.py | Documents the new aks update flags and provides examples for hosted-system conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…bnet-id to az aks update
2dfe2f4 to
1e040ed
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
please fix CI error first reneeli123 |
Live test results —
|
|
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
elvazhu521 Transient issue, the same step passed previously https://dev.azure.com/azclitools/public/_build/results?buildId=339434&view=logs&s=96ac2280-8cb4-5df5-99de-dd2da759617d&j=e2f732ac-2c19-5c7d-b3eb-bbf48e0f6d6e Just retriggered CI. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Live test results —
|
There was a problem hiding this comment.
Automated CI Summary
The current head commit (53b16c5) has a failing check:
- Azure.azure-cli (Build) —
failure: Build #20260819.22 failed
Please review the build log for the failure and push a fix. CI will re-run automatically on the next push.
|
🔔 Routing this PR to @Azure/act-observability-squad. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
reneeli123 there's a merge conflict in the PR |
|
Copilot resolve the merge conflicts in this pull request |
1 similar comment
|
Copilot resolve the merge conflicts in this pull request |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Discussed with PM we decided to add this as a preview feature first before go directly to GA, so I close the PR first. Thanks FumingZhang elvazhu521 ! |
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Related command
plain non-HOBO to HOBO conversion, keeps current AKS-managed networking
az aks update -g $RG -n $CLUSTER --enable-hosted-system
non-HOBO BYO VNet to HOBO conversion with system node pool subnet supplied
az aks update -g $RG -n $CLUSTER --enable-hosted-system --system-node-subnet-id $SYS
non-HOBO BYO VNet to HOBO conversion with system + user node pools subnet supplied
az aks update -g $RG -n $CLUSTER --enable-hosted-system --system-node-subnet-id $SYS --node-subnet-id $NODE
Description
Adds
--enable-hosted-system,--system-node-subnet-idand--node-subnet-idtoaz aks update, so an existing Automatic cluster can be converted to a Managed System Pool (HOBO) cluster in place. These flags already existed onaz aks create; this brings the update path to parity.Ports Azure/azure-cli-extensions#10199 and its follow-up Azure/azure-cli-extensions#10227.
get_enable_hosted_system()andvalidate_byo_hosted_system_subnets()now run inUPDATEmode; both previously early-returned outsideCREATE.--enable-hosted-system— unlike create, the subnets never imply it.--apiserver-subnet-idis not required on update;--node-subnet-idrequires--system-node-subnet-id. Omitted subnets leave the cluster's current networking untouched.update_hosted_system_profile()setshostedSystemProfile.{enabled,systemNodeSubnetId,nodeSubnetId}. Create-path behaviour is unchanged.Testing Guide
History Notes
[AKS]
az aks update: Add--enable-hosted-system,--system-node-subnet-idand--node-subnet-idto support converting an existing non-HOBO Automatic cluster to a Managed System Pool (HOBO) cluster, optionally with BYO VNetThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.