[Network] Add address prefix set commands - #34024
Open
rajanalavarnitha-wq wants to merge 1 commit into
Open
Conversation
Add preview AAZ commands to manage AddressPrefixSet child resources using API version 2025-09-01. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 957dff6d-b827-4578-85f8-1e0bc9258733
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
Ethan Yang (necusjz) and
Yong Zhang (yonzhan)
September 2, 2026 23:25
microsoft-github-policy-service
Bot
added
Network
1 task
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There’s at least one correctness/validation issue in the new update argument schema plus an eager-import pattern that can defeat AAZ loading optimizations and add unnecessary import cost.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds new preview AAZ-generated az network asg address-prefix-set command group to manage AddressPrefixSet child resources under an Application Security Group using Microsoft.Network API version 2025-09-01.
Changes:
- Introduces preview AAZ commands:
create,update,show,list,delete, andwaitfornetwork asg address-prefix-set. - Adds the command group/package wiring for the new subgroup under the AAZ
network asgnamespace. - Adds unit tests to verify command registration and key argument schema behaviors.
File summaries
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/tests/latest/test_address_prefix_set_commands.py | New unit tests validating command registration and argument schema requirements. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/__cmd_group.py | Registers the new preview command group network asg address-prefix-set. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/init.py | Package exports for the subgroup commands and command group. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_create.py | AAZ implementation for address-prefix-set create (PUT + LRO). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_update.py | AAZ implementation for address-prefix-set update (GET + instance update + PUT + LRO). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_show.py | AAZ implementation for address-prefix-set show (GET). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_list.py | AAZ implementation for address-prefix-set list (GET + pagination). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_delete.py | AAZ implementation for address-prefix-set delete (DELETE + LRO). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/address_prefix_set/_wait.py | AAZ implementation for address-prefix-set wait (poll GET). |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/asg/init.py | Adds subgroup exposure/imports for address-prefix-set under the ASG AAZ package. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+62
to
+66
| options=["--address-prefixes"], | ||
| help="Space-separated list of IPv4 or IPv6 address prefixes in CIDR notation.", | ||
| nullable=True, | ||
| ) | ||
| _args_schema.address_prefixes.Element = AAZStrArg(nullable=True) |
Comment on lines
+18
to
+22
| from .address_prefix_set import ( | ||
| __CMDGroup as AddressPrefixSetGroup, | ||
| Create as AddressPrefixSetCreate, | ||
| Delete as AddressPrefixSetDelete, | ||
| List as AddressPrefixSetList, |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Network |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Description
Adds preview Azure CLI AAZ commands for managing
AddressPrefixSetchild resources under an Application Security Group using Microsoft.Network API2025-09-01:az network asg address-prefix-set createaz network asg address-prefix-set updateaz network asg address-prefix-set showaz network asg address-prefix-set listaz network asg address-prefix-set deleteaz network asg address-prefix-set waitRelated changes
Testing
python -m pytest .../test_address_prefix_set_commands.py -q(2 passed)python -m flake8on changed command and test filesaz network asg createand new child command registration verifiedRelease request
Requested for Azure CLI 2.90.0 / September 2026. Inclusion is understood to be best effort because the original milestone deadline has passed.