Skip to content

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Sep 13, 2021

Reason for Change:

  • Making an http client interface
  • Testify - TestNew
  • Testify - existing cases
  • TestNew more cases
  • buildRoutes tests
  • GetNetworkConfiguration tests
  • CreateHostNCApipaEndpoint tests
  • DeleteHostNCApipaEndpoint tests
  • RequestIPAddress tests improvements
  • ReleaseIPAddress tests improvements
  • GetIPAddressesMatchingStates tests improvements
  • GetPodOrchestratorContext tests improvements
  • GetHTTPServiceData tests improvements

@rbtr rbtr mentioned this pull request Sep 14, 2021
3 tasks
@pjohnst5 pjohnst5 marked this pull request as ready for review September 14, 2021 18:40
@pjohnst5 pjohnst5 force-pushed the client-http-refactor branch from bade971 to 70fb5ab Compare September 14, 2021 18:54
@pjohnst5 pjohnst5 changed the title Client http refactor Client http refactor & testing Sep 14, 2021
@pjohnst5 pjohnst5 force-pushed the client-http-refactor branch from 4b46441 to 9d34b1c Compare September 14, 2021 21:13
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🚀

@pjohnst5 pjohnst5 merged commit 97f36db into Azure:master Sep 16, 2021
@pjohnst5 pjohnst5 deleted the client-http-refactor branch September 16, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants