test cns config and hns linux stub #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Just one question
| _, err := CreateHostNCApipaEndpoint("", cns.IPConfiguration{}, false, false, []cns.NetworkContainerRequestPolicies{}) | ||
| require.NoError(t, err) | ||
| require.NoError(t, DeleteHostNCApipaEndpoint("")) | ||
| } |
Contributor
There was a problem hiding this comment.
Is this test necessary?
rbtr
force-pushed
the
fun/cns-ut
branch
2 times, most recently
from
aafa015 to
ae3e8b2
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
ramiro-gamarra
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Up UT % in CNS by testing config behavior and HNS Linux stub (0 -> 85% and 0 -> 100%)
Issue Fixed:
Requirements:
Notes: