Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Sep 15, 2021

Reason for Change:

  • Creates an NNC-scoped client and moves NNC interactions in CNS to this client interface (simplifies NNC manipulations).
  • Updates crd/client to support NNC scoped client requirements.
  • Breaks the circular dependency between the NNC reconciler and the ipampoolmonitor by using scoped client.
  • Pulls dependency initialization out of these sub-components in to main where they can be injected and shared/reused.
  • Refactors NNC reconciler initialization and extracts the CNS state initialization from it so that the reconciler doesn't block main.
  • Removes lots of old code and adds lots of tests.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr added cns Related to CNS. work-in-progress labels Sep 15, 2021
@rbtr rbtr force-pushed the nnc-client branch 3 times, most recently from 871c31a to aeea0a8 Compare September 15, 2021 22:15
Copy link
Contributor

@ramiro-gamarra ramiro-gamarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few initial comments

@rbtr rbtr force-pushed the nnc-client branch 2 times, most recently from 2c243b1 to 27ff455 Compare September 21, 2021 17:58
rbtr added 12 commits October 5, 2021 18:50
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Copy link
Contributor

@ramiro-gamarra ramiro-gamarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some style nits, but one question in initCNS

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr
Copy link
Collaborator Author

rbtr commented Oct 6, 2021

@ramiro-gamarra updated

Copy link
Contributor

@ramiro-gamarra ramiro-gamarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rbtr rbtr merged commit c970d07 into Azure:master Oct 7, 2021
@rbtr rbtr deleted the nnc-client branch October 7, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants