Restore CNS State #101
Merged
Restore CNS State #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in Makefile
saiyan86
reviewed
Feb 23, 2018
| cmd := fmt.Sprintf("iptables -t nat -A POSTROUTING -m iprange ! --dst-range 168.63.129.16 -m addrtype ! --dst-type local ! -d %v -j MASQUERADE", | ||
| primaryNic.Subnet) | ||
| err = executeShellCommand(cmd) | ||
| err = common.SetOutboundSNAT(nicInfo.Subnet) |
Contributor
There was a problem hiding this comment.
For iptables commands, we can use this library:
https://github.com/coreos/go-iptables
| routingTable: routingTable, | ||
| state: serviceState, | ||
| }, nil | ||
|
|
sharmasushant
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR restores CNS state on reboot and enablws outbound snat rule if snat is enabled. Also it fixes the bug introduced in Makefile in previous PR.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: