Remove cns http client which did nothing #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohnst5
changed the title
Contributor
Author
|
Hi @feiskyer, can you take a look at this change which touches the multitenant scenario? I believe you had written tests for it, which are now slightly different. The gist of it is, there used to be a |
Member
|
+@thatmattlong could you confirm this change won't break things? @pjohnst5 please ensure the unit tests are fixed when making changes |
feiskyer
reviewed
Sep 21, 2021
cns/multitenantcontroller/multitenantoperator/multitenantcrdreconciler.go
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Could I get approval @thatmattlong ? |
thatmattlong
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
removing cns httpapi client which did nothing essentially