add histo metric for IP allocation latency per unique pod #1027
+312
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
ip-alloc-latency
branch
from
7d52389 to
38341f8
Compare
neaggarwMS
reviewed
Sep 22, 2021
neaggarwMS
reviewed
Sep 22, 2021
neaggarwMS
reviewed
Sep 22, 2021
cns/restserver/ipam.go
Outdated
| podInfo, returnCode, message := service.validateIPConfigRequest(req) | ||
|
|
||
| // remove this pod from the waiting for IP allocation set, if it is present | ||
| _ = service.podsPendingIPAllocation.Pop(podInfo.Key()) |
Member
There was a problem hiding this comment.
Actually with data deleting during release wont give us complete data. AFAIK, ContainerD calls ADD and if ADD fails to provision then it calls DEL followed by another ADD. If that is true, then we will never be able to truely evaluate the actual time it took to allocate an IP
Collaborator
Author
There was a problem hiding this comment.
I have updated the PR to use a custom queue-style structure for this:
- We will hold up to the last 250 (maxpods) unique pod IDs that we have seen, recording the timestamp that that pod was first seen.
- When an IP is allocated, we will pop the entry for that pod and record the duration since it was first seen.
- When the queue is full and we see a new pod, we will drop the oldest pod record by first-seen-timestamp and record the new pod.
rbtr
force-pushed
the
ip-alloc-latency
branch
2 times, most recently
from
083742e to
b30edbf
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
…allocation Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
thatmattlong
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Adds a data structure and metric for keeping track of IP allocation requests per pod and recording the total time taken to return an IP for that pod.
Issue Fixed:
Requirements:
Notes: