Reduce lock timeout and check pid same before cleaning up #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
force-pushed
the
tamanoha/lockfix
branch
from
7fd04e0 to
fc8b78c
Compare
tamilmani1989
force-pushed
the
tamanoha/lockfix
branch
from
fc8b78c to
274dfd6
Compare
rbtr
reviewed
Sep 28, 2021
|
|
||
| // Maximum number of retries before failing a lock call. | ||
| lockMaxRetries = 200 | ||
| lockMaxRetries = 100 |
Collaborator
There was a problem hiding this comment.
how quickly do we retry? this could go by very fast. should there be some exponential back-off, maybe?
Member
Author
There was a problem hiding this comment.
Isn't 10 seconds long enough? 100 retries with 100ms delay
Collaborator
There was a problem hiding this comment.
I don't know. Usually (like with http calls), we would do an exponential back-off where we wait maybe twice as long every time instead of a fixed interval (ex: 50ms, 100, 200, 400, 800, ...). But if 100x100ms is what we want, that's fine with me
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
ashvindeodhar
approved these changes
Sep 30, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: